Open
Conversation
Member
|
Hey, thank you for this! I've taken part of this and opened #148 to fix #83 . You've been marked as a co-author there. I'll review the other parts soon. We might want to take a different approach with the |
Member
|
@awissu if this branch is still relevant, would you mind resolving conflicts here? |
Member
|
This branch is based on the master branch that uses GTK 3. We have to rebase or recreate it if we really need this fix. |
Member
|
Ha yeah it looks like it wasn't a clean rebase 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
All of the fixes in patch have been tested on openSUSE.
The build and testing is here.