Skip to content

Allow adding custom environment values on DHSProto#109

Merged
simondsmart merged 1 commit intodevelopfrom
feature/extend_dhs_prot_with_env
Sep 18, 2025
Merged

Allow adding custom environment values on DHSProto#109
simondsmart merged 1 commit intodevelopfrom
feature/extend_dhs_prot_with_env

Conversation

@Ozaq
Copy link
Copy Markdown
Member

@Ozaq Ozaq commented Sep 8, 2025

Description

DHSProtocol now allows passing in custom environment values to be sent to the server.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@Ozaq Ozaq requested a review from simondsmart September 8, 2025 13:47
DHSProtocol now allows passing in custom environment values to be sent
to the server.
@Ozaq Ozaq force-pushed the feature/extend_dhs_prot_with_env branch from 22e6f5f to 7df53bc Compare September 8, 2025 14:32
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.20%. Comparing base (736ce0d) to head (7df53bc).

Files with missing lines Patch % Lines
src/metkit/mars/DHSProtocol.cc 0.00% 10 Missing ⚠️
src/metkit/mars/RequestEnvironment.cc 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
- Coverage    68.32%   68.20%   -0.13%     
===========================================
  Files          124      124              
  Lines         7340     7353      +13     
  Branches       732      732              
===========================================
  Hits          5015     5015              
- Misses        2325     2338      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simondsmart simondsmart merged commit 60f9b26 into develop Sep 18, 2025
166 of 172 checks passed
@simondsmart simondsmart deleted the feature/extend_dhs_prot_with_env branch September 18, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants