Issue 5676: Introduced useTcpForFallbackDnsResolving#6116
Conversation
|
we should have a test for this that checks TCP is actually used |
|
I added a test - I'm not really happy with it, this is Netty code it's testing, but it should do the job. |
| .handler(new ChannelInitializer<DatagramChannel>() { | ||
| @Override | ||
| protected void initChannel(DatagramChannel ch) throws Exception { | ||
| if (!enableUdp) { |
There was a problem hiding this comment.
I think here we should refactor to avoid binding the UDP channel instead of checking the init, like you have done for startTcp
There was a problem hiding this comment.
That's a bit more tricky, look into the newest commit for the proposed change
|
@cgm-aw can you address the confict on MockDnsServer with a rebase ? can you squash your contribution too ? |
Issue 5676: Added test Issue 5676: Reworked test Issue 5676: CR Remarks Issue 5676: CR Remarks Issue 5676: CR Remarks
cgm-aw
force-pushed
the
feature/master-issue-5676-tcp-dns
branch
from
94228d5 to
75504a1
Compare
|
@vietj sure done |
2 participants
See #5676