Skip to content

Remove obsolete disabled image descriptors#2775

Open
HeikoKlare wants to merge 2 commits into
eclipse-platform:masterfrom
HeikoKlare:debug-ui-remove-disabled-descriptors
Open

Remove obsolete disabled image descriptors#2775
HeikoKlare wants to merge 2 commits into
eclipse-platform:masterfrom
HeikoKlare:debug-ui-remove-disabled-descriptors

Conversation

@HeikoKlare

Copy link
Copy Markdown
Contributor

Image descriptors now carry an image descriptor for the disabled version of the image, so that it is not necessary to separately managed disabled image descriptors anymore:

This change thus removes the according shared disabled image descriptors from the debug.ui plugin.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   58m 22s ⏱️ + 2m 30s
 4 677 tests ±0   4 655 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 925 runs  ±0  11 772 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 7f63e64. ± Comparison against base commit dbb2884.

♻️ This comment has been updated with latest results.

Image descriptors now carry an image descriptor for the disabled version
of the image, so that it is not necessary to separately managed disabled
image descriptors anymore. This change thus removes the according shared
disabled image descriptors from the debug.ui plugin.
@HeikoKlare HeikoKlare force-pushed the debug-ui-remove-disabled-descriptors branch from 88f18eb to cd45620 Compare June 18, 2026 19:17
@eclipse-platform-bot

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

team/bundles/org.eclipse.compare.win32/META-INF/MANIFEST.MF
team/bundles/org.eclipse.compare.win32/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 9f42da29c4fd03557244f26b74152b605e8ff5ac Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 18 Jun 2026 19:23:33 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/team/bundles/org.eclipse.compare.win32/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.compare.win32/META-INF/MANIFEST.MF
index 009bca6d24..efb434c250 100644
--- a/team/bundles/org.eclipse.compare.win32/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.compare.win32/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.compare.win32;singleton:=true
-Bundle-Version: 1.3.800.qualifier
+Bundle-Version: 1.3.900.qualifier
 Bundle-Vendor: %providerName
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Eclipse-PlatformFilter: (osgi.os=win32)
diff --git a/team/bundles/org.eclipse.compare.win32/pom.xml b/team/bundles/org.eclipse.compare.win32/pom.xml
index 5e753e3055..0b02ab76d0 100644
--- a/team/bundles/org.eclipse.compare.win32/pom.xml
+++ b/team/bundles/org.eclipse.compare.win32/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.compare.win32</artifactId>
-  <version>1.3.800-SNAPSHOT</version>
+  <version>1.3.900-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@HeikoKlare HeikoKlare marked this pull request as ready for review June 19, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants