Skip to content

Show disabled icon for Disabled category in Breakpoint Enablement Grouping#2729

Open
SougandhS wants to merge 1 commit into
eclipse-platform:masterfrom
SougandhS:FixIcon
Open

Show disabled icon for Disabled category in Breakpoint Enablement Grouping#2729
SougandhS wants to merge 1 commit into
eclipse-platform:masterfrom
SougandhS:FixIcon

Conversation

@SougandhS

Copy link
Copy Markdown
Contributor

Before
Screenshot 2026-06-05 at 6 31 53 PM

After
Screenshot 2026-06-05 at 6 31 47 PM

@SougandhS SougandhS changed the title Show disabled icon for Disabled category Show disabled icon for Disabled category in Breakpoint Enablement Grouping Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   53m 19s ⏱️ -26s
 4 677 tests ±0   4 655 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 925 runs  ±0  11 772 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit de0014e. ± Comparison against base commit c45a7a7.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds UI support so the “Disabled” category in the Breakpoint Enablement grouping can display a disabled-specific icon, improving visual distinction in the Breakpoints view.

Changes:

  • Introduces a new BreakpointTypeCategory constructor that accepts both sort priority and an ImageDescriptor.
  • Updates the Breakpoint Enablement organizer to use a disabled-group image descriptor for the “Disabled” category.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/BreakpointTypeCategory.java Adds a new public constructor to allow specifying sort priority and an icon descriptor together.
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointEnablement.java Uses the new constructor to assign a disabled icon to the “Disabled” breakpoint category.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants