Skip to content

Helm: Allow configuring issuers for OIDC#2442

Merged
thjaeckle merged 1 commit into
eclipse-ditto:masterfrom
ATNoG:helm-oidc-issuers
May 15, 2026
Merged

Helm: Allow configuring issuers for OIDC#2442
thjaeckle merged 1 commit into
eclipse-ditto:masterfrom
ATNoG:helm-oidc-issuers

Conversation

@JCapucho
Copy link
Copy Markdown
Contributor

@JCapucho JCapucho commented May 11, 2026

Adds support for configuring the issuers1 option of OpenID Connect issuers in the helm chart values directly.

Footnotes

  1. https://eclipse.dev/ditto/installation-operating.html#openid-connect ↩

@JCapucho JCapucho force-pushed the helm-oidc-issuers branch from 57cb96e to 03dace2 Compare May 11, 2026 23:05
@JCapucho JCapucho marked this pull request as draft May 11, 2026 23:06
@JCapucho JCapucho force-pushed the helm-oidc-issuers branch from 03dace2 to 7f67d18 Compare May 11, 2026 23:24
@JCapucho JCapucho marked this pull request as ready for review May 11, 2026 23:24
@thjaeckle thjaeckle added this to the 3.9.0 milestone May 12, 2026
thjaeckle
thjaeckle requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wiring this through — the Helm change is small and backwards-compatible. Two changes requested before merging; see inline comments. The rest (example trailing-slash, comment phrasing) is just polish and not blocking.

One more thing: please bump the Helm chart version in deployment/helm/ditto/Chart.yaml — Helm chart linting requires a version bump when the chart content changes, otherwise the lint job fails.

Comment thread deployment/helm/ditto/values.yaml Outdated
Comment thread deployment/helm/ditto/service-config/gateway-extension.conf.tpl
thjaeckle added a commit to beyonnex-io/ditto that referenced this pull request May 12, 2026
@thjaeckle @claude
add missing 3.9.0 milestone items, adjust release date to 13.05.2026
932c51a 
Adds PRs eclipse-ditto#2440 (JFR CPU optimisations), eclipse-ditto#2441 / eclipse-ditto#2439 (AskTimeoutException
to 503), eclipse-ditto#2442 (Helm OIDC issuers), eclipse-ditto#2444 / eclipse-ditto#2443 (ssl-config fix), eclipse-ditto#2445
(MongoDB X509 auth), eclipse-ditto#2446 (stackless 4xx exceptions) and eclipse-ditto#2447
(configurable SSE backpressure) to the release notes and blogpost.

Renames the announcement post to 2026-05-13.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@thjaeckle thjaeckle removed this from the 3.9.0 milestone May 13, 2026
thjaeckle added a commit to beyonnex-io/ditto that referenced this pull request May 13, 2026
@thjaeckle @claude
update X509 entry to eclipse-ditto#2449 and drop eclipse-ditto#2442 f…
98880ad 
…rom 3.9.0 release notes

PR eclipse-ditto#2449 supersedes eclipse-ditto#2445 (review-feedback follow-up, opened from
eclipse-ditto/ditto since maintainer_can_modify was off on eclipse-ditto#2445).
PR eclipse-ditto#2442 (Helm OIDC issuers) will not be included in 3.9.0.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@JCapucho JCapucho force-pushed the helm-oidc-issuers branch from 7f67d18 to 7c98420 Compare May 13, 2026 14:53
@JCapucho
Copy link
Copy Markdown
Contributor Author

JCapucho commented May 13, 2026

@thjaeckle Sorry for the HOCON totally forgot to translate it.

I've added a comment explaining that the issuers option is in addition to the existing issuer value. I think this option makes more sense, because having the issuer option be accepted and then ignored completely is an unexpected behavior in my opinion.

thjaeckle
thjaeckle approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JCapucho for the contribution 👍

Will be part of Helm chart version 4.1.0

@thjaeckle
Copy link
Copy Markdown
Member

thjaeckle commented May 15, 2026

@JCapucho I just noticed the Helm linting still failed.
Can you please bump the Helm chart version to 4.1.0 by yourself as I don't have permissions to make changes on your fork?

@thjaeckle thjaeckle added this to the helm-chart-4.1.0 milestone May 15, 2026
@JCapucho JCapucho force-pushed the helm-oidc-issuers branch from 7c98420 to 61e3fcf Compare May 15, 2026 12:31
@JCapucho
feat(helm): Allow configuring issuers for OIDC
d143926 
Adds support for configuring the `issuers` option of OpenID Connect
issuers in the helm chart directly.
@JCapucho JCapucho force-pushed the helm-oidc-issuers branch from 61e3fcf to d143926 Compare May 15, 2026 12:33
@JCapucho
Copy link
Copy Markdown
Contributor Author

JCapucho commented May 15, 2026

@thjaeckle Done, not exactly sure why changes can't be made by maintainers, I'll check next time.

@thjaeckle thjaeckle merged commit 15490b0 into eclipse-ditto:master May 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees

@JCapucho JCapucho

Labels

Helm chart

Projects

None yet

Milestone

helm-chart-4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JCapucho @thjaeckle