Skip to content

Fix lints in report.htest.R by renaming conflicting variables#565

Merged
rempsyc merged 2 commits intomainfrom
copilot/fix-564
Sep 11, 2025
Merged

Fix lints in report.htest.R by renaming conflicting variables#565
rempsyc merged 2 commits intomainfrom
copilot/fix-564

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 11, 2025

This PR resolves all linting issues in R/report.htest.R by addressing object_overwrite_linter warnings about variable names that conflict with exported objects from base R packages.

The following variable names were renamed throughout the file to avoid conflicts:

  • tabletbl (conflicts with base::table)
  • texttxt (conflicts with graphics::text)
  • argscall_args (conflicts with base::args)

These changes affect multiple functions in the file:

  • report.htest()
  • report_table.htest()
  • report_statistics.htest()
  • report_parameters.htest()
  • report_model.htest()
  • report_info.htest()
  • report_text.htest()

All functionality remains unchanged - the package builds successfully and all existing tests for htest functionality continue to pass. The file now has zero linting issues while maintaining full backward compatibility.

Fixes #564.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: rempsyc <13123390+rempsyc@users.noreply.github.com>
Copilot AI changed the title [WIP] [Copilot]: Fix lints in report.htest.R Fix lints in report.htest.R by renaming conflicting variables Sep 11, 2025
Copilot AI requested a review from rempsyc September 11, 2025 01:58
@rempsyc rempsyc marked this pull request as ready for review September 11, 2025 02:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.25%. Comparing base (58c7492) to head (f7607a3).
⚠️ Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
R/report.htest.R 90.90% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   72.36%   72.25%   -0.12%     
==========================================
  Files          54       54              
  Lines        3684     3892     +208     
==========================================
+ Hits         2666     2812     +146     
- Misses       1018     1080      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rempsyc rempsyc merged commit b344438 into main Sep 11, 2025
26 of 28 checks passed
@rempsyc rempsyc deleted the copilot/fix-564 branch September 11, 2025 02:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.25%. Comparing base (58c7492) to head (f7607a3).
⚠️ Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
R/report.htest.R 90.90% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   72.36%   72.25%   -0.12%     
==========================================
  Files          54       54              
  Lines        3684     3892     +208     
==========================================
+ Hits         2666     2812     +146     
- Misses       1018     1080      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Copilot]: Fix lints in report.htest.R

2 participants