Skip to content

Architecture Issues - #2987

Open
KS-HTK wants to merge 69 commits into
e2nIEE:release/v4.0.0from
KS-HTK:issues/architecture-tangles
Open

Architecture Issues#2987
KS-HTK wants to merge 69 commits into
e2nIEE:release/v4.0.0from
KS-HTK:issues/architecture-tangles

Conversation

@KS-HTK

@KS-HTK KS-HTK commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

changed layout of test folder to omit it from the sonar architecture analysis

KS-HTK and others added 30 commits March 25, 2026 08:44
deprecated unused keyword args
* Hallo

* Hallo Leute

* adding first draft of simple_hl_plot a function to easily highlight buses and lines paired with a hover functionality

* added function to get a dataframe of all elements in the net

* add test
clean comments
renaming

* add test

* add docu

* add changelog entry
* updated ltds notebooks

* updated ltds notebooks, fixed LTDS converter
* added pytest split to tutorial_test pipeline

* added notebook test times
other formatting

Co-authored-by: V3 <mike.vogt@iee.fraunhofer.de>
* Fix copyright text formatting in LICENSE file

* Refactor copyright notice in LICENSE

Updated copyright notice formatting in LICENSE file following [upstream changes](licensee/licensee#950) to handle multi-line attribution.

---------

Co-authored-by: KS_HTK <2981026+KS-HTK@users.noreply.github.com>
…notebooks (PowerElectronicsConnection) (e2nIEE#2942)

Co-authored-by: David Heck <david.heck@iee.fraunhofer.de>
* added PowerElectronicsConnection to the LTDS converter, updated LTDS notebooks (PowerElectronicsConnection)

* updated LTDS notebooks for mapping Excel data
* updated ltds notebooks

* updated LTDS notebooks for mapping Excel data

* updated LTDS notebooks for mapping Excel data
* updated ltds notebooks

* updated LTDS notebooks for mapping Excel data

* updated LTDS notebooks for mapping Excel data

* UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook
* added check to check if vkr_percent values are reasonable.

* added changelog entry.

---------

Co-authored-by: KS_HTK <2981026+KS-HTK@users.noreply.github.com>
* added more diagnostic functions.

* added changelog entry.

* fixed a small bug, used the wrong value in the reactance field.
Updated the description of loading_percent.
* consider empty R dataframe in ucte conversion

* convert impedances and trafos with G/B=NaN to G/B=0

* change fillna for trafos and impedances to the ucte_parser

* fillna df if 0

* fix nan values in impedances and trafos

* ucte2pp: averaging voltages and clean up parser

* changelog entries for ucte2pp fixes

* average voltage setpoints using topological search instead of ucte name

* empty space at EOF

* fix codacy issue

* remove create_switch from pp_import_functions

* fix create_vsc functions

* changelog :)

* change symmetrical tap changer to 90 degree tap step degree

* correct handling of symmetrical PSTs in ucte2pp

* comment averaging function based on PR review

* changes ucte converter

* ucte2pp: add flag for voltage harmonization, with default false

* fix test

* fix tests and restrict tolerances a bit

---------

Co-authored-by: mrichter <mario.richter@iee.fraunhofer.de>
Co-authored-by: V3 <mike.vogt@iee.fraunhofer.de>
* change patch sizes for plot (e2nIEE#2733)

* fix patch sizes for plot only once (e2nIEE#2733)

`get_collection_sizes()` takes arguments to adjust the relative size of
an element.

---------

Co-authored-by: V3 <mike.vogt@iee.fraunhofer.de>
…ial vector (e2nIEE#2902)

* Fix runopp(init=results) warm-start handling in pips OPF

* Update CHANGELOG for upcoming release fixes and features

---------

Co-authored-by: jereOG <jerelang@users.noreply.github.com>
Co-authored-by: V3 <mike.vogt@iee.fraunhofer.de>
* integrated highlighting feature into simple_plot

* integrated hover feature into simple_plot

* update plotting tutorial

* adjust color
attribute name g0_us_per_km is incorrectly named as g0_nf_per_km in add_zero_impedance_parameters function.
…d_basic_std_types` parameter (e2nIEE#2961)

* Add basic std types flag to from_excel

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Fix reading bool

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Fix backward compatibility

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Silence sonarcloud and codacy

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Remove ruff ignore

---------

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* updated the issue templates to use the issue types instead of labels and title
minor changes in forms layouts

* fix for config not parsing by github (hopefully)
added documentation template
added emoji to template title for more visual guidance

* uniform formatting for templates

* added missing blank line at end of file
…#2969)

Only display a logger message if GetActiveScenario is not None
Added else case with a info message if no study case / scenario is active.
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* updated ltds notebooks

* updated LTDS notebooks for mapping Excel data

* updated LTDS notebooks for mapping Excel data

* UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* fix(cmin): fix cmin for low voltage 10% tolerance
…#2963)

* Fix reindex_buses

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Add allow_duplicate_index argument

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Fix unused import

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Fix test

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

---------

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* added/reformatted many docstrings

* added show_plot=False to test_plotting_toolbox

* refactored docstrings and added types

* fixed f-string in groups.py

* fixed incorrect type

* fixed incorrect type

* fixed missing import

* fixed import issue with specific lightsim2grid versions

* fixed mypy issues in contingency
refactored test in test_contingency

* fixed mypy issues

* updated var name
KS-HTK and others added 13 commits May 6, 2026 15:26
* fixed issue with voltage dependent loads.

* fixed typo in import

* removed unused imports

* Fixed test now failing due to nan instead of 0 for in_service=False
* fix failing runpp(net, consider_line_temperature=True) for grids with a mix of lines with alpha and without
added warning

* adapt test

* some structuring

* import default ALPHA

* rename ALPHA to ALPHA_TDPF due to duplicate (branch cols)

* fix NameError
…0909-0:2016) (e2nIEE#2962)

* Fixing usage of transformer impedance correction factor in min case of short-circuit calculations,
Adapting tests

* take case from net._options for trafo k_t fix (calculation only for max case)

* case was missing.

* fixed a broken test.

* fix test_all_currents.py

* min and max test case for test_trafo_impedace fixed

* Fix SyntaxError: invalid escape sequences in test_group.py (Python 3.14)

Use raw strings (r"...") for all regex match patterns containing escape
sequences like \(, \[, and \. which are SyntaxError in Python 3.14.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Christian Bredtmann <christian.bredtmann@envelio.de>
Co-authored-by: pawellytaev <pawel.lytaev@uni-kassel.de>
Co-authored-by: envelio-cb <88880102+envelio-cb@users.noreply.github.com>
Co-authored-by: V3 <mike.vogt@iee.fraunhofer.de>
Co-authored-by: KS_HTK <2981026+KS-HTK@users.noreply.github.com>
Co-authored-by: Reinhold Bertram <reinhold.bertram@envelio.de>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: IEECNB215543\gbanerjee <gourab.banerjee@iee.fraunhofer.de>
Signed-off-by: Yoshiki <yosinn1@gmail.com>
Co-authored-by: KS_HTK <2981026+KS-HTK@users.noreply.github.com>
Changes in PowerFactory2pp converter 

* Fixed test now failing due to nan instead of 0 for in_service=False

* get coords from (sub)stations
unpack only 2 coordinates, third one is 0
return None,None is no ext_grid can be created

* replace tuple with list to consolidate the code and fit the GeoJson standard

* tuple list ..
…s=True (e2nIEE#3024)

* cim2pp: mapping SV data to the assets with flag use_sv_data_for_assets=True
* add GeographicalRegion from eqbd profile

* add GeographicalRegion to cim_classes
…powerfactory (e2nIEE#2975)

* When importing static generators from powerfactory, first check if they are connected to a bus. If not, do not import them (previously, this was not checked for static gens that are reference machines, which led to import errors)

* Update to changelog

* simplified check for av_mode constq

---------

Co-authored-by: KS_HTK <2981026+KS-HTK@users.noreply.github.com>
Co-authored-by: pawellytaev <86314586+pawellytaev@users.noreply.github.com>
…EE#3020)

* Speed up CGMES trafo tap characteristic table build

Replace the per-group itertuples loop in _create_trafo_characteristic_table
with vectorized factorize and column-wise DataFrame construction. Output is
unchanged; convert time drops significantly on large CGMES networks.

* Speed up CGMES XML parsing with single-pass tag grouping
Group profile children by tag in one pass instead of calling findall per
element type, and streamline _parse_element attribute handling. Parsed CIM
tables and converted networks are unchanged on large CGMES test cases.

---------

Co-authored-by: Šime Pavlić <simepavlic@Simes-MacBook-Pro.local>
Co-authored-by: David Heck <david.heck@iee.fraunhofer.de>
Co-authored-by: mrifraunhofer <94368111+mrifraunhofer@users.noreply.github.com>
# Conflicts:
#	CHANGELOG.rst
#	test/consistency_checks.py
#	test/loadflow/test_scenarios.py
#	test/shortcircuit/test_1ph.py
#	test/shortcircuit/test_all_currents.py
#	test/shortcircuit/test_meshing_detection.py
#	test/shortcircuit/test_trafo3w.py
#	test/shortcircuit/test_transformer.py
@KS-HTK

KS-HTK commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

@vogt31337 suggested this to be part of the next major version.

@KS-HTK
KS-HTK changed the base branch from develop to release/v4.0.0 June 18, 2026 08:46
KS-HTK added 9 commits June 18, 2026 14:55
# Conflicts:
#	.gitignore
#	CHANGELOG.rst
#	pandapower/build_branch.py
#	pandapower/build_bus.py
#	pandapower/convert_format.py
#	test/api/test_sql_io.py
#	test/consistency_checks.py
#	test/run_tests.py
#	test/shortcircuit/test_1ph.py
#	test/shortcircuit/test_all_currents.py
#	test/shortcircuit/test_meshing_detection.py
#	test/shortcircuit/test_trafo3w.py
#	test/shortcircuit/test_transformer.py
#	tutorials/ieee_european_lv_time_series.ipynb
#	tutorials/ltds2pp_without_ssh.ipynb
#	tutorials/shortcircuit/sc_1ph_vector_group_trafo3w.ipynb
fixed duplicate function definition
moved required networks to the pandapower.networks package
@KS-HTK
KS-HTK force-pushed the issues/architecture-tangles branch from aab6519 to d700e90 Compare June 26, 2026 12:06
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@vogt31337 vogt31337 added this to the pandapower 4.0 milestone Jul 6, 2026
# Conflicts:
#	test/api/test_convert_format.py
#	test/api/test_diagnostic.py
#	test/api/test_opf_costfcn.py
#	test/consistency_checks.py
#	test/converter/test_from_opendss.py
#	test/loadflow/test_runpp.py
#	test/loadflow/test_runpp_3ph.py
#	test/loadflow/test_runpp_helm.py
#	test/opf/test_pandamodels_init_pq.py
#	test/opf/test_pandamodels_runpm.py
#	test/shortcircuit/test_1ph.py
#	test/shortcircuit/test_sc_single_bus.py
#	test/toolbox/test_compute_switch_flows.py
#	tutorials/ieee_european_lv_time_series.ipynb
#	tutorials/ltds2pp_without_ssh.ipynb
#	tutorials/shortcircuit/sc_1ph_vector_group_trafo3w.ipynb
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance miscellaneous tasks for housekeeping and maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.