Jao converter - #2755
Conversation
# Conflicts: # pandapower/converter/jao/from_jao.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2755 +/- ##
===========================================
- Coverage 71.62% 71.59% -0.03%
===========================================
Files 351 352 +1
Lines 37174 37797 +623
===========================================
+ Hits 26626 27062 +436
- Misses 10548 10735 +187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KS-HTK
left a comment
KS-HTK
left a comment
There was a problem hiding this comment.
Have not looked at all of the code as there is a lot to cover here… But some changes are required.
[CHANGED] refactored code
Refactored Code
… utils functions refactored code removed unused function
| ------ | ||
| KeyError | ||
| When primary/secondary voltage columns cannot be located via fuzzy matching. | ||
| """ |
There was a problem hiding this comment.
Why was a Documentation removed without replacement?
| def multi_str_repl(st: str, repl: list[tuple]) -> str: | ||
| for (old, new) in repl: | ||
| st = st.replace(old, new) | ||
| return st No newline at end of file |
|
|
KS-HTK
left a comment
KS-HTK
left a comment
There was a problem hiding this comment.
Please also review the Sonar Cloud warnings shown.
| @@ -1 +1,7 @@ | |||
| from .from_jao import from_jao No newline at end of file | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
remove this line, as it is only required for non utf-8 or python < 3. In python 3 file encoding is utf-8 by default.
(same for other files in this pr)
3 participants
converter now uses fuzzy matching with difflib module to find matching buses instead of using hard coded name corrections as well as table column names if they are inconsistent between files