Skip to content

Ic4 hr override#708

Merged
doudar merged 5 commits intodevelopfrom
IC4_HR_Override
Dec 19, 2025
Merged

Ic4 hr override#708
doudar merged 5 commits intodevelopfrom
IC4_HR_Override

Conversation

@doudar
Copy link
Copy Markdown
Owner

@doudar doudar commented Dec 18, 2025

No description provided.

@doudar doudar requested a review from Copilot December 18, 2025 23:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves ERG mode responsiveness and fixes HRM connection filtering to prevent the IC4's built-in heart rate sensor from overriding explicitly configured heart rate monitors.

  • Adds configurable PID window for ERG mode power table transitions
  • Refactors timer logic to use comparison-based timing for better clarity
  • Implements HRM connection filtering to respect user configuration
  • Tunes resistance control parameters for faster response

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Main.cpp Adjusts resistance control thresholds and multipliers for faster response (threshold from 3 to 1, multiplier from 2 to 3)
src/ERG_Mode.cpp Refactors timer logic, adds PID window logic, adjusts power table lookup with offset, reduces ERG seek time cap from 4s to 3s, and adds delay tracking
src/BLE_Client.cpp Implements HRM connection filtering to check configured HRM against device name/address before registering
include/settings.h Defines new ERG_MODE_PID_WINDOW constant (20) for power table transition behavior
CHANGELOG.md Documents changes for version 25.12.17 including HRM filtering fix and ERG improvements

Comment thread src/BLE_Client.cpp
Comment thread src/ERG_Mode.cpp Outdated
Comment thread src/ERG_Mode.cpp Outdated
@doudar doudar merged commit c06bf67 into develop Dec 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants