Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves ERG mode responsiveness and fixes HRM connection filtering to prevent the IC4's built-in heart rate sensor from overriding explicitly configured heart rate monitors.
- Adds configurable PID window for ERG mode power table transitions
- Refactors timer logic to use comparison-based timing for better clarity
- Implements HRM connection filtering to respect user configuration
- Tunes resistance control parameters for faster response
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Main.cpp | Adjusts resistance control thresholds and multipliers for faster response (threshold from 3 to 1, multiplier from 2 to 3) |
| src/ERG_Mode.cpp | Refactors timer logic, adds PID window logic, adjusts power table lookup with offset, reduces ERG seek time cap from 4s to 3s, and adds delay tracking |
| src/BLE_Client.cpp | Implements HRM connection filtering to check configured HRM against device name/address before registering |
| include/settings.h | Defines new ERG_MODE_PID_WINDOW constant (20) for power table transition behavior |
| CHANGELOG.md | Documents changes for version 25.12.17 including HRM filtering fix and ERG improvements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.