Change warning annotations to notices regarding ignored inputs#241
Open
Vanley wants to merge 1 commit into
Open
Change warning annotations to notices regarding ignored inputs#241Vanley wants to merge 1 commit into
Vanley wants to merge 1 commit into
Conversation
ento
reviewed
Oct 16, 2024
Comment on lines
92
to
94
| if (base) { | ||
| core.warning(`'base' input parameter is ignored when action is triggered by pull request event`) | ||
| core.notice(`'base' input parameter is ignored when action is triggered by pull request event`) | ||
| } |
Comment on lines
89
to
91
| if (ref) { | ||
| core.warning(`'ref' input parameter is ignored when 'base' is set to HEAD`) | ||
| core.notice(`'ref' input parameter is ignored when 'base' is set to HEAD`) | ||
| } |
There was a problem hiding this comment.
This can be deleted too, I think. I don't see any if clause here that evaluates base === git.HEAD like for the return statement above.
Lines 80 to 85 in de90cc6
Author
|
thanks @ento for review Will keep this pr short and sweet about the github annotation and information feedback during the github action run. If you are more familiar with the project and improvements which can be made around it, please create separate pr with those changes! Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When input parameter is ignored, annotation should just inform about it.
Available annotations on the github actions (https://github.com/actions/toolkit/tree/main/packages/core):
