feat(docx): extract VML images with v:imagedata elements#3343
Open
feat(docx): extract VML images with v:imagedata elements#3343
Conversation
Add VML image support with EMF/WMF conversion and consolidate image handler code. Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesWaiting for:
This rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
✅ DCO Check Passed Thanks @ceberam, all your commits are properly signed off. 🎉 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for extracting VML images with
v:imagedataelements from Word documents. While VML shapes (vector graphics like rectangles, ovals, lines) were already supported for positioning, embedded images referenced via VMLv:imagedataelements were not being extracted.Problem
When converting Word documents containing VML images (commonly used for embedded Visio drawings, EMF/WMF files, and OLE objects), these images were missing from the output. The backend only detected DrawingML images (using
a:blipelements) but missed VML images (usingv:imagedataelements).Solution
v:imagedataelements_handle_vml_pictures()method that:v:imagedatarelationship IDs_get_image_from_relationship()- Unified image retrieval from relationship IDs_add_picture_to_doc()- Unified picture element addition_convert_elements_via_docx()- Unified DOCX→PDF→PNG conversion (supports both single and multiple elements)Key Distinction
v:imagedataelements are now detected and their embedded images are extractedTesting
docx_vml_images.docxwith 2 VML images and ground truthv:imagedataelementsFiles Changed
docling/backend/msword_backend.py- VML image extraction + code consolidation (~150 lines added, ~100 lines removed via consolidation)tests/data/docx/docx_vml_images.docx- Test document with VML imagestests/data/groundtruth/docling_v2/docx_vml_images.docx.json- Ground truthResolves #3298
Checklist: