docs(uspto): improve documentation of USPTO XML parser security config#3338
Merged
PeterStaar-IBM merged 1 commit intomainfrom Apr 21, 2026
Merged
docs(uspto): improve documentation of USPTO XML parser security config#3338PeterStaar-IBM merged 1 commit intomainfrom
PeterStaar-IBM merged 1 commit intomainfrom
Conversation
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
✅ DCO Check Passed Thanks @ceberam, all your commits are properly signed off. 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PeterStaar-IBM
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the security configuration of the USPTO XML parser. The analysis shows that the original configuration was actually secure, but the security rationale was not well documented.
Key Security Insight
defusedxmldistinguishes between:forbid_*flagsfeature_external_*flagsThe critical protection comes from
feature_external_ges=False, which prevents external entities from being resolved/fetched, regardless of whether they're declared.Why This Configuration is Secure
Checklist: