fix(service): allow passing HybridChunkerOptions to chunk()#3337
Open
alexdmds wants to merge 2 commits intodocling-project:mainfrom
Open
fix(service): allow passing HybridChunkerOptions to chunk()#3337alexdmds wants to merge 2 commits intodocling-project:mainfrom
alexdmds wants to merge 2 commits intodocling-project:mainfrom
Conversation
…ptions to chunk() chunk(), submit_chunk() and _submit_chunk_task() previously only accepted a ChunkerKind enum and always created HybridChunkerOptions() with default values, making tokenizer, max_tokens, merge_peers and include_raw_text impossible to configure from the client. These methods now accept either a ChunkerKind (unchanged behaviour) or a fully instantiated HybridChunkerOptions / HierarchicalChunkerOptions, which is then forwarded as-is to the service endpoint. Adds three unit tests covering backward-compat (ChunkerKind), custom hybrid options, and hierarchical options. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
✅ DCO Check Passed Thanks @alexdmds, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, Alexis De Monts <alexis.demonts@cleyrop.com>, hereby add my Signed-off-by to this commit: cc526c0 Signed-off-by: Alexis De Monts <alexis.demonts@cleyrop.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
chunk(),submit_chunk()and_submit_chunk_task()only accepted aChunkerKindenum and always instantiated
HybridChunkerOptions()with default values internally.This made
tokenizer,max_tokens,merge_peersandinclude_raw_textimpossibleto configure from the client, even though these fields are defined on
HybridChunkerOptions.Fix
The three methods now accept either a
ChunkerKind(unchanged behaviour) or a fullyinstantiated
HybridChunkerOptions/HierarchicalChunkerOptions, which is forwardedas-is to the service endpoint.
Tests
Three unit tests added using
httpx.MockTransport:ChunkerKind.HYBRIDstill routes to/v1/chunk/hybrid/file/asynctokenizer,max_tokens,include_raw_textappear in the request bodyHierarchicalChunkerOptionsroutes to/v1/chunk/hierarchical/file/async