ci: implement phase 1 path-based workflow skipping by geoHeil · Pull Request #3332 · docling-project/docling

geoHeil · 2026-04-20T19:00:59Z

Summary

add PR concurrency to the CI entry workflows
add simple path-based change detection before calling the reusable CI and docs workflows
gate the expensive checks jobs by changed paths while keeping pyproject.toml, uv.lock, and Dockerfile as CI-triggering paths

Part of #3327.

Testing

Ruby YAML parse for .github/workflows/ci.yml, .github/workflows/ci-docs.yml, and .github/workflows/checks.yml
git diff --check

Notes

this intentionally uses simple path-based skipping only for phase 1
no GitHub-hosted workflow run was executed locally

The action dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d is not allowed in docling-project/docling because all actions must be from a repository owned by docling-project, created by GitHub, or match one of the patterns: DavidAnson/markdownlint-cli2-action@v16, astral-sh/setup-uv@v5, astral-sh/setup-uv@v6, astral-sh/setup-uv@v7, codecov/codecov-action@*, codecov/codecov-action@v2, codecov/codecov-action@v5, demodrive-ai/llms-txt-action@ad720693843126e6a73910a667d0eba37c1dea4b, denoland/setup-deno@*, dependabot/*, docker/*, docker/setup-qemu-action@v3, dorny/test-reporter*, gradle/actions/*, gradle/actions/wrapper-validation@v5, jreleaser/release-action@*, madrapps/jacoco-report@v1.7.2, mikepenz/action-junit-report*, mikepenz/action-junit-report@v4, msys2/setup-msys2@v2, peter-evans/create-pull-request*, pypa/cibuildwheel@*, pypa/gh-action-pypi-publish@release/v1, redhat-actions/buildah-build@*, redhat-actions/push-to-registry@*, sigstore/gh-action-sigstore-python@v3.0.0...

we will have to modify the list of allowed CI actions

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

github-actions · 2026-04-20T19:01:09Z

✅ DCO Check Passed

Thanks @geoHeil, all your commits are properly signed off. 🎉

mergify · 2026-04-20T19:01:38Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

dolfim-ibm

The new action is now whitelisted, this can be tried out with a new commit+push.

dolfim-ibm · 2026-04-21T06:12:30Z

+            needs.changes.outputs.full_matrix_override == 'true' &&
+            '["3.10", "3.11", "3.12", "3.13", "3.14"]'
+          ) ||
+          (
+            github.event_name == 'pull_request' &&
+            contains(github.event.pull_request.labels.*.name, 'tests:full') &&
+            '["3.10", "3.11", "3.12", "3.13", "3.14"]'
+          ) ||
+          '["3.10"]'


better keep the python versions in a variable/input, otherwise we have too many places to maintain.

Addressed in f5d2b9d: the PR workflow now defines DEFAULT_PYTHON_VERSIONS and FULL_PYTHON_VERSIONS once and passes them through changes job outputs instead of repeating the JSON matrix in the reusable workflow call.

dolfim-ibm · 2026-04-21T06:18:17Z

+          enable-cache: true
+
+      - name: Install minimal trusted lint and typing dependencies
+        run: uv sync --frozen --only-group pr-fast-checks --no-install-project


just checking my understanding: the checkout action above is cloning the base branch (main) so it is always using the deps in main, right?

Yes, that is the intended behavior. Addressed in f5d2b9d by documenting it inline: pull_request_target checks out the trusted base commit for dependency installation, then fetches the PR head separately as FETCH_HEAD for diff/overlay checks only.

dolfim-ibm · 2026-04-21T06:22:15Z

+name: "Run PR Fast Checks"
+
+on:
+  pull_request_target:


should we temporary make it a PR CI action? otherwise we cannot test it before merge.

sounds like a good idea.

but somehow my permissions are not there to test drive the CI change on the branch

could you either grant me other/more permissions or allow the CI change see also in the top level description what is not allowed right now)

ah - just saw it seems t obe whitelisted now. let me try again

As a wrote, it is done already

#3332 (review)

dolfim-ibm · 2026-04-21T06:23:11Z

+  pull_request_target:
+    types: [opened, reopened, synchronize, ready_for_review]
+    paths:
+      - ".github/workflows/pr-fast-checks.yml"


We might not need any filter here, we are anyway including almost all...

Addressed in 4d767f8: removed the trigger-level paths: filter from pr-fast-checks.yml. The workflow now runs for all PR target events, while .github/scripts/run_pr_fast_checks.py still performs its own changed-file targeting and exits quickly when there are no Python/notebook targets.

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

codecov · 2026-04-21T07:24:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

geoHeil · 2026-04-21T08:51:36Z

Temporary normal pull_request validation for the heavy CI/docs workflows completed successfully on this PR. I removed those normal pull_request triggers again so same-repo PR branches do not produce duplicate push + pull_request CI runs. The dedicated trusted pull_request_target fast-check workflow remains enabled for PR validation.

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

geoHeil added 4 commits April 20, 2026 20:05

ci: add phase 1 path-based workflow skipping

eeb1599

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: add fast pull_request_target lint checks

35cc43b

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: keep pr fast checks cheap

1472847

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: expand full matrix triggers

9185c7a

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

geoHeil mentioned this pull request Apr 20, 2026

ci: implement phase 1 path-based workflow skipping #3331

Closed

geoHeil added 2 commits April 20, 2026 21:10

ci: enable same-repo and merge queue checks

a3c8919

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: harden pull_request_target fetch inputs

84d9f09

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

dolfim-ibm reviewed Apr 21, 2026

View reviewed changes

geoHeil added 9 commits April 21, 2026 08:42

ci: address phase 1 workflow review

f5d2b9d

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: grant reusable checks permissions

9b9d2da

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: temporarily enable pr fast checks validation

f2433dc

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: allow first run of pr fast checks

85ba460

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: load pr fast check script for first validation

085865e

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: format pr fast check script

6e03250

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: guard temporary pr fast check script fallback

afac121

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: use pr metadata for temporary fast check validation

f93d049

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: remove temporary pr fast checks trigger

f7bf9bb

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: disable duplicate pull request runs

cf1a990

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

ci: run fast pr checks without path trigger filter

4d767f8

Signed-off-by: Georg Heiler <georg.kf.heiler@gmail.com>

geoHeil requested a review from dolfim-ibm April 21, 2026 12:08

geoHeil mentioned this pull request Apr 22, 2026

Discussion: speed up CI with path-based gating, modular skipping, and a cheaper PR matrix #3327

Open

Conversation

geoHeil commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Notes

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Apr 20, 2026

Merge Protections

🟢 Enforce conventional commit

Uh oh!

dolfim-ibm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 21, 2026

Codecov Report

Uh oh!

geoHeil commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

geoHeil commented Apr 20, 2026 •

edited

Loading

github-actions Bot commented Apr 20, 2026 •

edited

Loading