Connections#25336
Conversation
Introduce a new Enterprise > Security section for Docker OIDC, positioned between Enforce sign-in and Roles and permissions. Adds overview, connection management, and rulesets/subject claims pages, including GitHub Actions workflow setup and Admin Console management guidance. Also adds a Docker OIDC card to the Security landing page and registers the feature in summary.yaml for summary-bar metadata.
Correct links and wording, align login-action with repo convention, and update the Security grid icon.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
New Docker OIDC documentation is well-structured and technically clear. One high-severity inconsistency between the prose and the rendered summary-bar subscription badge needs resolution before merge, plus several medium style issues.
|
|
||
| Each ruleset contains the following fields: | ||
|
|
||
| - **Label**: A name for the ruleset. |
There was a problem hiding this comment.
[MEDIUM] Bold used for conceptual list labels — may not qualify as UI elements
STYLE.md reserves bold exclusively for UI elements (buttons, menus, field labels). **Label**, **Rules**, **Resources**, and **Scopes** appear in a conceptual definition list. If these are the exact names of labeled fields in the Admin Console form UI, bold is correct. If they're conceptual terms describing what a ruleset contains, bold should be removed and the list rewritten as plain prose bullets.
There was a problem hiding this comment.
These are the exact names of the UI elements
There was a problem hiding this comment.
Thank you for confirming! In that case, the bold formatting is correct per STYLE.md. Resolved.
- Reword involves broad phases to enumerate the actual phases - Fix per-GitHub Action basis to per-workflow basis - Fix GitHub Action workflows to GitHub Actions workflows - Normalize OIDC connections casing throughout create-manage.md - Change This doc to This page in rulesets-claims.md - Update GitHub link text to OpenID Connect Reference - Remove trailing whitespace on two lines - Remove trailing periods from all What's next bullets
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR adds new Docker OIDC documentation. There is one high-severity factual error (contradictory subscription requirements) and two medium-severity style violations. Please address the subscription contradiction before merging, as it will directly mislead users about who can use this feature.
|
|
||
| To create an OIDC connection, you need: | ||
|
|
||
| - A Docker Core subscription |
There was a problem hiding this comment.
[HIGH] Contradictory subscription requirements: 'Docker Core' vs 'Team or Business'
Line 14 states "Docker OIDC is available for organizations with Docker Team or Business subscriptions," but the Prerequisites section on line 20 lists "A Docker Core subscription" as a requirement. These are different subscription tiers and directly contradict each other. One of these needs to be corrected to match the actual availability requirement.
|
|
||
| Each ruleset contains the following fields: | ||
|
|
||
| - **Label**: A name for the ruleset. |
There was a problem hiding this comment.
[MEDIUM] Bold lead-in list format violates style guide
The style guide explicitly calls out **Term**: Description bullet formatting as "marketing-style list formatting" to avoid. Bold should be used only for UI elements (buttons, menus, field labels that appear verbatim in the interface). If Label, Rules, Resources, and Scopes are actual UI field labels, describe them as plain text bullets or restructure as prose. For example:
Instead of:
- **Label**: A name for the ruleset.
- **Rules**: One or more conditions...
Use:
- Label: A name for the ruleset.
- Rules: One or more conditions...
Or rewrite as prose if appropriate.
There was a problem hiding this comment.
they are UI elements
There was a problem hiding this comment.
Thanks for the clarification! Since these are actual UI field labels that appear in the interface, keeping them bold is correct per the style guide. I apologize for the false positive.
2 participants
Draft PR