Use constant strings in error messages.

[zluudg]

Summary by CodeRabbit

• Bug Fixes
  • Improved error message consistency for MQTT engine operations. Start, stop, and restart commands now return standardized error messages when the engine encounters issues, providing clearer and more predictable error reporting.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The changes standardize error handling in three MQTT engine methods (StartEngine, StopEngine, RestartEngine) by replacing propagated error messages with fixed error strings. Success paths remain unchanged.

Changes

Cohort / File(s)	Change Summary
Error message standardization in MQTT engine methods mqtt_utils.go	StartEngine, StopEngine, and RestartEngine methods now return fixed error strings instead of propagating underlying error messages when the MQTT engine responds with an error

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Simple, repetitive pattern applied consistently across three methods
• Only error string values changed; no logic or control flow modifications
• No public API or method signature changes

Poem

🐰 Error strings unified with care,
Three methods now respond so fair,
StandardizedMessages take the lead,
Clarity's all we'll ever need! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Use constant strings in error messages' accurately reflects the main change: replacing dynamic error messages with fixed constant strings across three MQTT engine methods (StartEngine, StopEngine, RestartEngine).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch leon/fix-dependabot-pr-50

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

mqtt_utils.go (1)

582-585: Remove dead error handling or update StopEngine to report errors.

Verification confirms the error handling block at lines 582-585 is unreachable. The StopEngine closure (lines 245-259) never sets r.Error = true—it only populates the Status field. Since MqttEngineResponse.Error defaults to false, the if r.Error condition will never trigger.

Either remove the dead code block or update StopEngine to propagate errors when failures occur. Currently, the handler remains defensive/unused.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3b797e and 082cc7a.

📒 Files selected for processing (1)

• mqtt_utils.go (3 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2024-12-13T08:58:36.397Z

Learnt from: johanix
Repo: dnstapir/tapir PR: 21
File: mqtt_utils.go:415-416
Timestamp: 2024-12-13T08:58:36.397Z
Learning: In the Go file `mqtt_utils.go`, the `xxxPubSubToTopic` function is no longer used and should be removed once it's confirmed it's not needed.

Applied to files:

• mqtt_utils.go