use 'dnstapir' prefix for files and folders

[zluudg]

Summary by CodeRabbit

• New Features

  • Updated system branding and naming conventions to DNS TAPIR throughout the application.

• Documentation

  • Clarified enroll command help text to reference "DNS TAPIR enrollment credentials."

• Chores

  • Aligned internal configuration and embedded template references with DNS TAPIR naming.
  • Adjusted temporary file naming used on error to match DNS TAPIR conventions.

[coderabbitai]

Walkthrough

Updated embed directives, public filename constants, CLI flag help text, and an internal temp-file prefix to replace the "tapir-" prefix with "dnstapir-" in nodeman-related code.

Changes

Cohort / File(s)	Summary
Template & naming updates cmd/nodeman.go	Changed embed sources from cfgfiles/tapir-*.toml/yaml to cfgfiles/dnstapir-*.toml/yaml; updated constants FILENAME_TAPIR_POP, FILENAME_TAPIR_EDM, FILENAME_TAPIR_CLI to dnstapir-prefixed filenames; adjusted enroll flag help text to "DNS TAPIR"; changed temp-file prefix from tapir-cli-tmp- to dnstapir-cli-tmp-.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Leon/packaging fixes #43: Modifies the same filename constants and nodeman enroll/CLI template handling, likely touching the same naming changes.

Suggested reviewers

• eest

Poem

🐇 I hopped through code with gentle cheer,
Renamed the tags so names are clear,
From tapir to dnstapir I bounded light,
Templates aligned, everything right 🐾

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "use 'dnstapir' prefix for files and folders" accurately and directly summarizes the main change in the changeset. The primary modifications involve updating file references and constant names from the "tapir-" prefix to the "dnstapir-" prefix throughout cmd/nodeman.go, which is exactly what the title conveys. The title is concise, clear, and specific enough that a reviewer scanning the project history would immediately understand the core intent of the change. While the PR also includes a minor user-facing text update, the title appropriately focuses on the most significant change without needing to enumerate every detail.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch leon/rename-to-dnstapir-prefix

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2eb01be and e08e8fd.

📒 Files selected for processing (1)

• cmd/nodeman.go (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• cmd/nodeman.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee7f550 and 2eb01be.

📒 Files selected for processing (1)

• cmd/nodeman.go (4 hunks)

🔇 Additional comments (3)

cmd/nodeman.go (3)

664-664: LGTM!

The temporary file prefix update from "tapir-cli-tmp-" to "dnstapir-cli-tmp-" is consistent with the PR objective of adopting the "dnstapir" prefix throughout the codebase.

---

98-105: Template files verified successfully; export concerns unfounded.

The verification confirms:

1. Renamed template files exist (lines 98-105): All three dnstapir-*.{toml,yaml} files are present at cmd/cfgfiles/, and old tapir- prefixed files have been removed. Embed directives are valid. ✓

2. Exported constants (lines 138-140): While FILENAME_TAPIR_* constants are exported, they are used exclusively within cmd/nodeman.go and not referenced elsewhere in the codebase, so the value changes are not breaking changes. ✓

3. Flag description and temp file prefix: Both changes are consistent with the systematic renaming from tapir- to dnstapir- prefix. ✓

---

138-140: Incomplete refactoring: defaults.go constants not updated to match cmd/nodeman.go naming.

The three exported constants in cmd/nodeman.go (lines 138-140) have been renamed to use the dnstapir-* prefix and are used consistently within that file (lines 207, 211, 215). However, the related constants in defaults.go (DefaultPopCfgFile and DefaultTapirCliCfgFile) were not updated and still reference the old tapir-* filenames.

While these renamed constants in cmd/nodeman.go are only used internally within that file, they are exported symbols. If external packages depend on the constant values, this creates an API inconsistency. Additionally, for consistency across the codebase, defaults.go should be updated as well.

Action required: Either update defaults.go to match the new dnstapir-* naming, or clarify why the two sets of constants should use different filename patterns.

[eest]

LGTM