Add custom evaluation metrics OpenAPI endpoints#1196
Merged
Conversation
DO-rrao
reviewed
Jun 30, 2026
DO-rrao
reviewed
Jun 30, 2026
sshirolkar
force-pushed
the
sshirolkar/custom-metrics
branch
from
597212b to
6ed5ff7
Compare
Address review feedback: created_at, updated_at, and deleted_at in the shared apiCustomEvaluationMetricConfig schema are server-assigned, so mark them readOnly so they only surface on responses and are not treated as client-settable on create/update requests. Co-authored-by: Cursor <cursoragent@cursor.com>
Address review feedback: drop the internal Figma reference from add_to_library and reword deleted_at and the associated_presets/preset schema descriptions in terms of what the API consumer sees rather than internal dashboard/picker behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
sshirolkar
added a commit
to sshirolkar/godo
that referenced
this pull request
Jun 30, 2026
Adds the EvaluationMetricSource enum and Source field to align with the custom evaluation metrics OpenAPI contract (digitalocean/openapi#1196), so the SDK no longer drops `source` from API responses. This lets consumers distinguish custom metrics from built-in ones. Co-authored-by: Cursor <cursoragent@cursor.com>
The add_to_library field was removed from the cthulhu CustomEvaluationMetricConfig contract (reserved as of commit adb2d389); every custom metric is now persisted. Drop the property from apiCustomEvaluationMetricConfig and from the create/update curl examples to keep the spec in sync with the source-of-truth proto. Co-authored-by: Cursor <cursoragent@cursor.com>
DO-rrao
added a commit
to digitalocean/godo
that referenced
this pull request
Jul 1, 2026
* add support for custom metrics rpcs * address review comments * add source field to EvaluationMetric Adds the EvaluationMetricSource enum and Source field to align with the custom evaluation metrics OpenAPI contract (digitalocean/openapi#1196), so the SDK no longer drops `source` from API responses. This lets consumers distinguish custom metrics from built-in ones. Co-authored-by: Cursor <cursoragent@cursor.com> * remove add_to_library from CustomEvaluationMetricConfig The add_to_library field was removed from the cthulhu contract (every custom metric is now persisted), so drop it from the SDK struct, the test fixture, and the related assertions to stay in sync with the source of truth. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Radhika Rao <rrao@digitalocean.com> Co-authored-by: Cursor <cursoragent@cursor.com>
DO-rrao
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run lint -- specification/DigitalOcean-public.v2.yamlMade with Cursor