feat(crossplane): activate iam Policy MRD for the eks-ci permissions boundary#2612
Open
devantler wants to merge 2 commits into
Open
feat(crossplane): activate iam Policy MRD for the eks-ci permissions boundary#2612devantler wants to merge 2 commits into
devantler wants to merge 2 commits into
Conversation
Contributor
Author
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A review of the EKS CI identity (aws#4) found a privilege-escalation path: the CI role could create an IAM role with arbitrary permissions and pass it to EC2, escaping its smoke-test scope. The fix caps every role it creates with a permissions boundary — which needs the
Policymanaged-resource kind active, currently off by design (#2564).What
Activates
policies.iam.aws.m.upbound.ioin the aws activation policy and grants the aws tenant RBAC over it — one kind, only for the boundary; broad Policy/RolePolicyAttachment use stays off. Consumed by the boundary manifest in aws#4, which should merge after this.Part of #2326.
Note: the merge queue is currently wedged on the pending
GHCR_TOKENrotation (see #2611) — this draft is mergeable once that secret is rotated.