fix: include externalToken in AuthenticationResponse Codable - #151
Merged
Conversation
externalToken was added as a property (#150) but not to the custom CodingKeys/encode/decode, so JSONEncoder and JSONDecoder silently dropped it. Add it to the coding keys and encode/decode it (optional).
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment focuses on the primary contributor who has significant work on the affected file, ensuring expertise and familiarity with the codebase.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Adds externalToken to AuthenticationResponse's custom Codable so it survives JSONEncoder/JSONDecoder round-trips.
No issues found — good bones! The field is String? and the coding uses decodeIfPresent/encodeIfPresent, matching the optional type and the sibling pattern. Woof!
itaihanski
enabled auto-merge (squash)
July 14, 2026 06:07
asafshen
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
Follow-up to #150
Description
Add missing encoding for
externalTokenMust