Skip to content
This repository was archived by the owner on Mar 30, 2026. It is now read-only.

#1225 Upgrade SQLAlchemy to v2 - #1684

Draft
EvanParish wants to merge 5 commits into
mainfrom
1225-sqlalchemy-v2
Draft

#1225 Upgrade SQLAlchemy to v2#1684
EvanParish wants to merge 5 commits into
mainfrom
1225-sqlalchemy-v2

Conversation

@EvanParish

Copy link
Copy Markdown

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

issue #1225

This PR upgrades the SQLAlchemy dependency to v2 and contains related changes.

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only
  • Dependency update

How Has This Been Tested?

How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured the latest master is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column

@EvanParish EvanParish linked an issue Mar 6, 2024 that may be closed by this pull request
13 tasks
@EvanParish EvanParish added the dependencies Pull requests that update a dependency file label Mar 6, 2024
Comment thread requirements-app.txt
@@ -71,7 +71,7 @@ rfc3339-validator >= 0.1.4
sentry-sdk[flask] >= 1.40.5

# 10 December 2022: Ignoring security vulnerability 51668 in Makefile. It is fixed in >= 2.0.0b1.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this comment and the related code in Makefile can be removed if SQLAlchemy is successfully upgraded.

Michael Wellman added 3 commits March 14, 2024 07:34
App starts
Uncommented lines out that were not causing issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade SQLAlchemy to v2

2 participants