[CB] Multi-paste support in Data Editor - #4271
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
TIP This summary will be updated as you push new changes. Give us feedback
devnaumov
requested changes
Apr 8, 2026
|
|
||
| const handleCellKeyDown: DataGridProps['onCellKeyDown'] = (_, event) => { | ||
| gridSelectedCellCopy.onKeydownHandler(event); | ||
| gridSelectedCellPaste.onKeydownHandler(event); |
Member
There was a problem hiding this comment.
The event will be fired in readonly mode and probably will modify result which is not expected. probably should be called after readonly check or inside hook
Contributor
Author
There was a problem hiding this comment.
added the check inside paste handler so we dont forget this case if we reuse it somewhere
| } | ||
|
|
||
| try { | ||
| const clipboardText = await navigator.clipboard.readText(); |
Member
There was a problem hiding this comment.
please use ClipboardService.read
| tableData.editor.setMany(updates); | ||
| } | ||
| } catch (error) { | ||
| notificationService.logException(error as Error, 'ata_grid_table_paste_error'); |
Member
There was a problem hiding this comment.
ata_grid_table_paste_error -> data_grid_table_paste_error
Contributor
Author
There was a problem hiding this comment.
removed since it is handled in ClipboardService.read()
SychevAndrey
previously approved these changes
Apr 8, 2026
Wroud
previously approved these changes
Apr 8, 2026
devnaumov
previously approved these changes
Apr 8, 2026
sergeyteleshev
dismissed stale reviews from devnaumov, Wroud, and SychevAndrey
via
April 8, 2026 13:58
309e254
devnaumov
previously approved these changes
Apr 8, 2026
devnaumov
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/8670