Allow CLI passwords starting with dash characters#1842
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Allow CLI passwords starting with dash characters#1842rolandwalker wants to merge 1 commit intomainfrom
rolandwalker wants to merge 1 commit intomainfrom
Conversation
Allow the argument to --password (and aliases) to start with a dash character, by stopping to pass the "flag_value" parameter to click. Now --password (and aliases) always take a value at the CLI, unless given in the final position, in which case the flag works as a request for an interactive prompt. This retains the mechanism of EMPTY_PASSWORD_FLAG_SENTINEL, just does not use "flag_value" to set the sentinel value. There still remains the special-casing of DSNs after --password flags, which, while not related to the dash-character bug, still defines some special strings which can't be used as CLI password arguments.
rolandwalker
force-pushed
the
RW/allow-leading-hyphen-on-cli-passwords
branch
from
e0bc634 to
1fe534a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow the argument to
--password(and aliases) to start with a dash character, by stopping to pass theflag_valueparameter toclick.Now
--password(and aliases) always take a value at the CLI, unless given in the final position, in which case the flag works as a request for an interactive prompt.This retains the mechanism of
EMPTY_PASSWORD_FLAG_SENTINEL, just does not useflag_valueto set the sentinel value.There still remains the special-casing of DSNs after
--passwordflags, which, while not related to the dash-character bug, still defines some special strings which can't be used as CLI password arguments.Fixes #1752.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).