serve dataflint JSON via reflective Jetty servlet on spark 4#72
Closed
serve dataflint JSON via reflective Jetty servlet on spark 4#72
Conversation
Replace the WebUIPage-based JSON flow on Spark 4 with a Jetty ServletContextHandler whose Servlet is a java.lang.reflect.Proxy over whichever servlet API is on the classpath at runtime. Lets the same artifact run on stock Spark 4 (jakarta.servlet) and Databricks Runtime 17.3 (javax.servlet) without compile-time coupling. Each renderJson body moves verbatim into a producer lambda in DataflintReflectiveServletBuilder; the WebUIPage subclasses are deleted because they would fail JVM verification on javax-only runtimes. DataflintJettyUtils drops its jakarta.servlet import, finding the ServletHolder constructor by parameter probing instead. Spark 3 keeps the original page-based flow via the new usesReflectiveEndpoints flag on the page factory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the WebUIPage-based JSON flow on Spark 4 with a Jetty ServletContextHandler whose Servlet is a java.lang.reflect.Proxy over whichever servlet API is on the classpath at runtime. Lets the same artifact run on stock Spark 4 (jakarta.servlet) and Databricks Runtime 17.3 (javax.servlet) without compile-time coupling. Each renderJson body moves verbatim into a producer lambda in DataflintReflectiveServletBuilder; the WebUIPage subclasses are deleted because they would fail JVM verification on javax-only runtimes. DataflintJettyUtils drops its jakarta.servlet import, finding the ServletHolder constructor by parameter probing instead. Spark 3 keeps the original page-based flow via the new usesReflectiveEndpoints flag on the page factory.