refactor: upgrading arrow-rs to 58.1.0#19684
Open
SkyFan2002 wants to merge 11 commits intodatabendlabs:mainfrom
Open
refactor: upgrading arrow-rs to 58.1.0#19684SkyFan2002 wants to merge 11 commits intodatabendlabs:mainfrom
SkyFan2002 wants to merge 11 commits intodatabendlabs:mainfrom
Conversation
github-actions
bot
added
the
pr-refactor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae795ec35f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
SkyFan2002
force-pushed
the
vk/33a6-arrow-rs
branch
from
ae795ec to
ab027d2
Compare
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
Preserve ParquetTableInfo schema descriptors by serializing the printed schema and falling back to ArrowSchemaConverter only when Arrow 58 can no longer parse the schema text during fragment init. Update the fuse_encoding sqllogictest expectation to match the Arrow 58 parquet metadata size reported for c2.
Update standalone explain sqllogictests for Arrow 58 metadata changes in read size reporting and pruning stat cost formatting.
Refresh fold_agg standalone explain output for the new pruning stats cost formatting reported under Arrow 58.
Remove the temporary 'writeable' entry from .typos.toml and revert standalone explain sqllogictest pruning costs back to <slt:ignore> so timing-style output stays non-deterministic in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is