Skip to content

Fixes to handle JSON params, files clause in copy into, reserved words#63

Merged
everpcpc merged 5 commits intodatabendlabs:mainfrom
PlaidCloud:fixes
Jun 5, 2025
Merged

Fixes to handle JSON params, files clause in copy into, reserved words#63
everpcpc merged 5 commits intodatabendlabs:mainfrom
PlaidCloud:fixes

Conversation

@rad-pat
Copy link
Copy Markdown
Contributor

@rad-pat rad-pat commented Jun 4, 2025

Reserved words updated with output from select * from information_schema.keywords - is that correct? It might be good to have some automated process that updates this list when a new version of Databend is released.

I added the AVRO file format now it is handled by Databend

Allows use of JSON in parameters, and files clause was not working correctly in copy into, added fix and test for that.

@bohutang bohutang requested a review from everpcpc June 4, 2025 12:34
@everpcpc
Copy link
Copy Markdown
Member

everpcpc commented Jun 5, 2025

INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/runner/work/databend-sqlalchemy/databend-sqlalchemy/databend_sqlalchemy/databend_dialect.py", line 1043
INTERNALERROR>     result += f" FILES = ({', '.join(["'{0}'".format(f) for f in copy_into.files])})"
INTERNALERROR>                                                                                      ^
INTERNALERROR> SyntaxError: f-string: unmatched '['

@rad-pat
Copy link
Copy Markdown
Contributor Author

rad-pat commented Jun 5, 2025

INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/home/runner/work/databend-sqlalchemy/databend-sqlalchemy/databend_sqlalchemy/databend_dialect.py", line 1043
INTERNALERROR>     result += f" FILES = ({', '.join(["'{0}'".format(f) for f in copy_into.files])})"
INTERNALERROR>                                                                                      ^
INTERNALERROR> SyntaxError: f-string: unmatched '['

Ah, python 3.12 vs lesser version issue. Will fix 👍

@everpcpc everpcpc merged commit c5be5fb into databendlabs:main Jun 5, 2025
2 checks passed
@rad-pat rad-pat deleted the fixes branch June 5, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants