backport: Merge bitcoin#28725, 28771, 28825, 28814, 28546, 28076, 28741, 28727, 22764

[vijaydasmp]

No description provided.

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• backport: #22764 #28597 #7238 - backport: #22764 #28597

Please coordinate with the authors of these PRs to avoid merge conflicts.

[thepastaclaw]

✅ Review complete (commit 63494e8)

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 659d7c7eb2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Exclude src/fs.h from std::filesystem lint

The new Rust lint runner hardcodes :(exclude)src/util/fs.h, but this repository’s safe wrapper lives at src/fs.h, so git grep always matches the intentional std::filesystem usage in that wrapper and the lint fails every run. In the CI flow (ci/lint/06_script.sh) this makes the lint stage fail even on clean trees; reproducing with cargo run --manifest-path test/lint/test_runner/Cargo.toml reports matches from src/fs.h and exits non-zero.

Useful? React with 👍 / 👎.

[coderabbitai]

Walkthrough

The PR modernizes Python type hints to use built-in generics (list/dict), replaces a custom random_bytes helper with random.randbytes across tests, and adds a Rust-based CI lint test runner (Cargo manifest and main.rs) plus build/invocation steps in lint scripts and Docker entrypoint. It adds LLVM symbolizer env vars for fuzzing and test runner integration, refines Qt translation source lists in Makefiles, tweaks LCOV invocations, adds test script constants, enables a clang-tidy check, and introduces wallet changes: a new CWalletTx::updateState(interfaces::Chain&) and calling code that delegates state reconciliation to it.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant CWallet as CWallet
participant CWalletTx as CWalletTx
participant Chain as interfaces::Chain
CWallet->>CWalletTx: LoadToWallet -> for each wtx, call updateState(chain())
CWalletTx->>Chain: query stored block (findBlock / inActiveChain)
alt block found and active
Chain-->>CWalletTx: return block hash + height (active)
CWalletTx-->>CWalletTx: keep TxStateConfirmed/TxStateConflicted with height
else block missing or not active
Chain-->>CWalletTx: not found / not active
CWalletTx-->>CWalletTx: set TxStateInactive{} (clear block-related fields)
end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making this check inconclusive as no content exists to evaluate.	Add a brief description summarizing the purpose and impact of these backported changes, or reference the upstream Bitcoin PRs being merged.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title references a Bitcoin backport (PR numbers) which corresponds to the substantial changeset including LCOV options, Rust lint runner, Python type annotations, test utilities, and wallet transaction state updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 12

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

contrib/seeds/makeseeds.py (1)

16-174: ⚠️ Potential issue | 🟠 Major

contrib/** directory change needs explicit justification/approval.

This PR modifies contrib/seeds/makeseeds.py, which conflicts with the repository rule that contrib/** should not be changed unless specifically prompted. Please confirm this exception is intentionally approved for this backport.

As per coding guidelines: "Do not make changes to build system files (guix-build*), release artifacts, or avoid changes to .github, depends, ci, contrib, and doc directories unless specifically prompted".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contrib/seeds/makeseeds.py` around lines 16 - 174, The change touches
contrib/seeds/makeseeds.py which per repo policy requires explicit approval;
update the PR to include a clear justification and approval for modifying
contrib (mention it's a backport or bugfix), list the affected symbols (e.g.
parseip, resolveasn, filterbyasn), reference the original issue/PR and target
branch, and obtain an explicit maintainer approval comment or label before
merging. Ensure the PR description includes the reason, risk assessment, and a
short note that contributors were notified/approved so reviewers can accept the
contrib/** change.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ci/lint/04_install.sh`:
- Around line 37-44: The script currently tests only if the LINT_RUNNER_PATH
directory exists, which misses the case where the test_runner binary is absent;
update the guard to check the executable itself (use -x on the binary path, e.g.
"${LINT_RUNNER_PATH}/test_runner" or ensure LINT_RUNNER_PATH points to the
binary) so the cargo build and mv steps run when the binary is missing; adjust
surrounding logic that creates the directory (mkdir -p) and the subsequent mv
target/debug/test_runner to work with the new executable-path check and keep
using CI_RETRY_EXE for apt-get as before.

In `@ci/test/00_setup_env_native_fuzz.sh`:
- Line 19: The export of LLVM_SYMBOLIZER_PATH points to llvm-symbolizer-17 while
the build uses clang-19 (mismatched major versions), and changes to ci/**
require explicit scope approval; update the symbolizer to match the compiler
(e.g., set LLVM_SYMBOLIZER_PATH to llvm-symbolizer-19) or make the clang
invocation use clang-17 so versions align, and add a brief CI note or PR
description confirming that modifying files under ci/** is authorized by the
team/CI owners; locate the assignment to LLVM_SYMBOLIZER_PATH and the clang-19
invocation in the script and adjust one of them (or add an approval comment) to
resolve the mismatch and policy concern.

In `@contrib/devtools/utils.py`:
- Line 13: This change touches contrib/devtools/utils.py (function
determine_wellknown_cmd) which per guidelines requires explicit scope approval;
update the PR description or backport metadata to state that modifications under
contrib/ are intentional and approved, and include a short justification and the
approver's identifier (e.g., maintainer or release manager) so reviewers can
verify the exception, and optionally add a one-line comment above
determine_wellknown_cmd noting the accepted contrib-path change for future
readers.

In `@contrib/message-capture/message-capture-parser.py`:
- Line 14: The file uses PEP 585 generics (e.g., list[Any]) which breaks Python
3.7/3.8 compatibility and touches the contrib directory; either add "from
__future__ import annotations" as the first import in the module to allow
built-in generics on older Pythons, or revert to typing generics by importing
List/Dict/etc. from typing and replace occurrences of list[Any] at the locations
referenced (around the existing "from typing import Any, Optional" import and
usages near lines 95 and 192) with typing.List/typing.Dict forms; also undo any
unnecessary edits to the contrib/ directory unless this change was explicitly
requested.

In `@src/Makefile.qt.include`:
- Line 499: Remove the duplicate prerequisite by editing the translate target to
list $(QT_FORMS_UI) only once; locate the translate target definition (the line
starting with "translate:") and remove the extra $(QT_FORMS_UI) token so the
prerequisite list contains a single reference to $(QT_FORMS_UI), leaving other
prerequisites (e.g., $(srcdir)/qt/dashstrings.cpp, $(BITCOIN_QT_BASE_CPP),
$(BITCOIN_QT_WINDOWS_CPP), $(BITCOIN_QT_WALLET_CPP), $(BITCOIN_QT_H),
$(BITCOIN_MM)) unchanged.

In `@src/wallet/wallet.h`:
- Around line 531-537: Edit the precondition comment in src/wallet/wallet.h to
remove the duplicated word "able" and clarify the awkward sentence about block
references: change "it won't be able able to determine the the height of the
last block processed, or the heights of blocks referenced in transaction, and
might cause assert failures." to a clean phrasing such as "it won't be able to
determine the height of the last processed block or the heights of blocks
referenced by transactions, which may cause assert failures." Update the comment
block near the wallet online/block index precondition so it reads clearly and
contains no duplicated words.

In `@test/functional/interface_rest.py`:
- Line 67: The parameter annotation for query_params in the function signature
is incorrect because it defaults to None but is typed as dict[str, typing.Any];
update the annotation to an explicit optional type such as
typing.Optional[dict[str, typing.Any]] (or from typing import Optional and use
Optional[dict[str, Any]]) so that query_params: Optional[dict[str, typing.Any]]
= None (reference the query_params parameter in the function signature in
test/functional/interface_rest.py).

In `@test/functional/mempool_datacarrier.py`:
- Around line 51-55: The five test-only uses of randbytes (assignments to
default_size_data, too_long_data, small_data, one_byte, zero_bytes) trigger
S311; update each line to append a noqa suppression comment like "# noqa: S311"
and include a brief inline note such as "# test-only pseudo-random data,
non-crypto" so the linter ignores these non-cryptographic PRNG warnings while
documenting intent.

In `@test/functional/p2p_v2_misbehaving.py`:
- Line 93: The test uses non-cryptographic randomness in the assignment to
self.transport_version (random.randbytes(5)); add a Ruff S311 suppression
comment on that line to indicate this is test-only pseudo-random data (not used
for crypto) so the linter ignores it. Locate the assignment to
self.transport_version and append a comment like "# noqa: S311 -- test-only
non-crypto randomness" (or equivalent project linter suppression) to suppress
the warning.

In `@test/functional/rpc_psbt.py`:
- Around line 601-604: The test uses randbytes() to generate pseudo-random test
data for variables hash_ripemd160, preimage_ripemd160, hash_sha256,
preimage_sha256, hash_hash160, preimage_hash160, hash_hash256 and
preimage_hash256; add inline suppression comments "noqa: S311" to those
randbytes() call lines to silence the insecure randomness warning (S311) from
Ruff/flake8-bandit since this is non-cryptographic test data, keeping the calls
and variable names (randbytes, hash_ripemd160, preimage_ripemd160, etc.)
unchanged.

In `@test/functional/test_framework/v2_p2p.py`:
- Line 158: The linter flags use of the random module as cryptographically
unsafe; add inline suppressions by appending the comment "# noqa: S311 -
test-only pseudo-random data" to each test-only pseudo-random call: the call to
random.randrange(...), the assignment using random.randbytes(garbage_len)
(self.sent_garbage = random.randbytes(garbage_len)), and the two
random.randint(...) usages so each line ends with that exact noqa comment to
silence S311 for these test-only data generators.

In `@test/lint/test_runner/src/main.rs`:
- Around line 35-52: The git grep invocation in the git().args([...]) call
incorrectly excludes "src/util/fs.h" instead of the actual wrapper "src/fs.h",
causing false positives, and it blindly interprets .status().success() which
treats exit code 1 (no matches) same as exit code 2 (command error); update the
args to exclude "src/fs.h" and change the handling of the Command status
produced by git().status() so you explicitly match on the exit code or use
status.code() to treat 0 as found, 1 as not found (returning Ok/false), and any
other nonzero code as an error (returning Err with the command failure details)
for the git() call used here.

---

Outside diff comments:
In `@contrib/seeds/makeseeds.py`:
- Around line 16-174: The change touches contrib/seeds/makeseeds.py which per
repo policy requires explicit approval; update the PR to include a clear
justification and approval for modifying contrib (mention it's a backport or
bugfix), list the affected symbols (e.g. parseip, resolveasn, filterbyasn),
reference the original issue/PR and target branch, and obtain an explicit
maintainer approval comment or label before merging. Ensure the PR description
includes the reason, risk assessment, and a short note that contributors were
notified/approved so reviewers can accept the contrib/** change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bb475e86-4fbe-4b62-ba4b-20e62a937774

📥 Commits

Reviewing files that changed from the base of the PR and between 56bceb4 and 659d7c7.

⛔ Files ignored due to path filters (1)

• test/lint/test_runner/Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (38)

• Makefile.am
• ci/lint/04_install.sh
• ci/lint/06_script.sh
• ci/lint/docker-entrypoint.sh
• ci/test/00_setup_env_native_fuzz.sh
• contrib/devtools/circular-dependencies.py
• contrib/devtools/utils.py
• contrib/guix/security-check.py
• contrib/guix/symbol-check.py
• contrib/macdeploy/macdeployqtplus
• contrib/message-capture/message-capture-parser.py
• contrib/seeds/makeseeds.py
• src/.clang-tidy
• src/Makefile.qt.include
• src/fs.h
• src/test/util/script.h
• src/wallet/db.cpp
• src/wallet/transaction.cpp
• src/wallet/transaction.h
• src/wallet/wallet.cpp
• src/wallet/wallet.h
• test/functional/interface_rest.py
• test/functional/mempool_datacarrier.py
• test/functional/p2p_net_deadlock.py
• test/functional/p2p_v2_misbehaving.py
• test/functional/rpc_psbt.py
• test/functional/test_framework/script.py
• test/functional/test_framework/test_framework.py
• test/functional/test_framework/util.py
• test/functional/test_framework/v2_p2p.py
• test/functional/test_framework/wallet.py
• test/functional/wallet_fast_rescan.py
• test/fuzz/test_runner.py
• test/lint/README.md
• test/lint/lint-files.py
• test/lint/lint-include-guards.py
• test/lint/test_runner/Cargo.toml
• test/lint/test_runner/src/main.rs

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Check for the executable, not just the directory.

Line 37 only checks -d "${LINT_RUNNER_PATH}". If the directory exists but test_runner is missing (e.g., prior partial run), the build is skipped and downstream execution fails. Guard on the binary path (-x) instead.

Suggested fix

 export LINT_RUNNER_PATH="/lint_test_runner"
-if [ ! -d "${LINT_RUNNER_PATH}" ]; then
+if [ ! -x "${LINT_RUNNER_PATH}/test_runner" ]; then
   ${CI_RETRY_EXE} apt-get install -y cargo
   (
     cd ./test/lint/test_runner || exit 1
     cargo build
     mkdir -p "${LINT_RUNNER_PATH}"
-    mv target/debug/test_runner "${LINT_RUNNER_PATH}"
+    mv target/debug/test_runner "${LINT_RUNNER_PATH}/test_runner"
   )
 fi

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ci/lint/04_install.sh` around lines 37 - 44, The script currently tests only
if the LINT_RUNNER_PATH directory exists, which misses the case where the
test_runner binary is absent; update the guard to check the executable itself
(use -x on the binary path, e.g. "${LINT_RUNNER_PATH}/test_runner" or ensure
LINT_RUNNER_PATH points to the binary) so the cargo build and mv steps run when
the binary is missing; adjust surrounding logic that creates the directory
(mkdir -p) and the subsequent mv target/debug/test_runner to work with the new
executable-path check and keep using CI_RETRY_EXE for apt-get as before.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect compiler and symbolizer pins in the changed CI setup script.
rg -n 'BITCOIN_CONFIG|LLVM_SYMBOLIZER_PATH|clang-[0-9]+|llvm-symbolizer-[0-9]+' ci/test/00_setup_env_native_fuzz.sh -C1

# Extract and compare major versions (read-only check).
python - <<'PY'
import re
from pathlib import Path

p = Path("ci/test/00_setup_env_native_fuzz.sh").read_text()
clang = re.search(r"clang-(\d+)", p)
symbolizer = re.search(r"llvm-symbolizer-(\d+)", p)

print("clang_major =", clang.group(1) if clang else "not found")
print("symbolizer_major =", symbolizer.group(1) if symbolizer else "not found")

if clang and symbolizer and clang.group(1) != symbolizer.group(1):
    print("RESULT: version mismatch detected (needs explicit justification).")
else:
    print("RESULT: no major-version mismatch detected in this file.")
PY

Repository: dashpay/dash

Length of output: 446

---

Address LLVM version mismatch and verify CI-scope approval.

Line 19 pins llvm-symbolizer-17 while line 18 compiles with clang-19. This major-version mismatch between the compiler and symbolizer can degrade stack trace quality during fuzzing and sanitizer reporting. Additionally, this change modifies the ci/** directory, which per coding guidelines should not be changed unless explicitly prompted. Confirm that this CI modification is in scope and that the symbolizer version mismatch is intentional.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ci/test/00_setup_env_native_fuzz.sh` at line 19, The export of
LLVM_SYMBOLIZER_PATH points to llvm-symbolizer-17 while the build uses clang-19
(mismatched major versions), and changes to ci/** require explicit scope
approval; update the symbolizer to match the compiler (e.g., set
LLVM_SYMBOLIZER_PATH to llvm-symbolizer-19) or make the clang invocation use
clang-17 so versions align, and add a brief CI note or PR description confirming
that modifying files under ci/** is authorized by the team/CI owners; locate the
assignment to LLVM_SYMBOLIZER_PATH and the clang-19 invocation in the script and
adjust one of them (or add an approval comment) to resolve the mismatch and
policy concern.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Contrib-path modification needs explicit scope approval.

Line 13 changes contrib/devtools/utils.py, but this PR context does not explicitly document an exception for contrib/** edits. Please confirm and document that this directory is intentionally in-scope for this backport.

As per coding guidelines, "Do not make changes to build system files (guix-build*), release artifacts, or avoid changes to .github, depends, ci, contrib, and doc directories unless specifically prompted".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contrib/devtools/utils.py` at line 13, This change touches
contrib/devtools/utils.py (function determine_wellknown_cmd) which per
guidelines requires explicit scope approval; update the PR description or
backport metadata to state that modifications under contrib/ are intentional and
approved, and include a short justification and the approver's identifier (e.g.,
maintainer or release manager) so reviewers can verify the exception, and
optionally add a one-line comment above determine_wellknown_cmd noting the
accepted contrib-path change for future readers.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check Python version requirements across the project

# Check for python_requires in setup files
fd -e py -e cfg -e toml -e txt 'setup|pyproject|requirements|README' --exec rg -n 'python_requires|Python [0-9]|python.*3\.[0-9]+' {}

# Check shebang lines for version hints
rg -n '^#!/usr/bin/env python3\.[0-9]+' --type py

# Check for other uses of built-in generics (list[], dict[])
rg -n 'def.*:\s*(list|dict)\[' --type py | head -20

Repository: dashpay/dash

Length of output: 814

---

🌐 Web query:

Python 3.9 PEP 585 built-in generic types support

💡 Result:

PEP 585 introduces support for using built-in collection types like list, dict, tuple, set, frozenset, and type as generics directly in type hints in Python 3.9, without needing to import equivalents from the typing module (e.g., list[str] instead of typing.List[str]). This uses class_getitem for parameterization, available at runtime. Importing the typing versions is deprecated for Python 3.9+, with removal planned after Python 3.9's end-of-life in October 2025. Other collections like collections.deque and collections.defaultdict also gain generic support. Type checkers must recognize these, and with from future import annotations (since 3.7), this works in annotations earlier. Example: def greet_all(names: list[str]) -> None: ...

Citations:

• 1: https://peps.python.org/pep-0585/
• 2: https://www.python.org/dev/peps/pep-0585/
• 3: https://docs.python.org/3.9/library/typing.html
• 4: https://docs.python.org/3/whatsnew/3.9.html

---

Remove built-in generic syntax or add future annotations import to maintain Python 3.7+ compatibility.

The changes use PEP 585 syntax (list[Any]) which requires Python 3.9+, but the project minimum version is Python 3.7+ per setup.py. This breaks compatibility with Python 3.7 and 3.8. Either revert to typing.List, or add from __future__ import annotations at the top of the file to enable this syntax on earlier versions.

Additionally, changes to contrib/ directory should be avoided unless specifically prompted per coding guidelines.

Also applies to: 95-95, 192-192

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contrib/message-capture/message-capture-parser.py` at line 14, The file uses
PEP 585 generics (e.g., list[Any]) which breaks Python 3.7/3.8 compatibility and
touches the contrib directory; either add "from __future__ import annotations"
as the first import in the module to allow built-in generics on older Pythons,
or revert to typing generics by importing List/Dict/etc. from typing and replace
occurrences of list[Any] at the locations referenced (around the existing "from
typing import Any, Optional" import and usages near lines 95 and 192) with
typing.List/typing.Dict forms; also undo any unnecessary edits to the contrib/
directory unless this change was explicitly requested.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Duplicate $(QT_FORMS_UI) in prerequisites.

$(QT_FORMS_UI) appears twice in the prerequisites list. While Make handles duplicates gracefully, this appears to be an oversight and should be cleaned up.

🔧 Proposed fix

-translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)
+translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)
	translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Makefile.qt.include` at line 499, Remove the duplicate prerequisite by
editing the translate target to list $(QT_FORMS_UI) only once; locate the
translate target definition (the line starting with "translate:") and remove the
extra $(QT_FORMS_UI) token so the prerequisite list contains a single reference
to $(QT_FORMS_UI), leaving other prerequisites (e.g.,
$(srcdir)/qt/dashstrings.cpp, $(BITCOIN_QT_BASE_CPP), $(BITCOIN_QT_WINDOWS_CPP),
$(BITCOIN_QT_WALLET_CPP), $(BITCOIN_QT_H), $(BITCOIN_MM)) unchanged.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n test/functional/mempool_datacarrier.py | sed -n '45,60p'

Repository: dashpay/dash

Length of output: 949

---

🏁 Script executed:

# Check if there's a linting configuration file that specifies S311 rules
fd -type f -name ".*lint*" -o -name "*lint*.yml" -o -name "*lint*.yaml" -o -name ".pylintrc" -o -name "pyproject.toml" -o -name "setup.cfg" | head -20

Repository: dashpay/dash

Length of output: 226

---

🌐 Web query:

S311 Bandit randbytes pseudo-random security issue

💡 Result:

S311 is a linter rule in Ruff (derived from flake8-bandit and Bandit's B311) that flags the use of non-cryptographic pseudo-random number generators from Python's random module, such as random.randbytes, random.random, random.randrange, random.choice, random.sample, random.getrandbits, and random.Random. These are unsuitable for security-sensitive operations like generating tokens, keys, or nonces because they are predictable and can be brute-forced or reverse-engineered by attackers. The "security issue" is not a vulnerability or exploit in the random module itself, but a potential security risk if developers mistakenly use these functions in cryptographic contexts. Python documentation explicitly warns against this and recommends the secrets module (e.g., secrets.token_bytes for random.randbytes equivalent) for cryptographically secure randomness. This rule was expanded over time: - Added random.Random support (Bandit PR #940, 2023). - Added random.randbytes (Bandit PR #1096, 2024). - Added random.sample, randrange, getrandbits (Bandit PR #1235, 2025). - Ruff synced these updates (PR #10313, 2024). No evidence of a specific "S311 Bandit randbytes pseudo-random security issue" beyond this linting rule. "Bandit" refers to the PyCQA/bandit security linter, not a product or vulnerability named Bandit. There are no associated CVEs; it's a best-practice warning (CWE-330: Use of Insufficiently Random Values).

Citations:

• 1: https://docs.astral.sh/ruff/rules/suspicious-non-cryptographic-random-usage/
• 2: Add random.randbytes to blacklist calls PyCQA/bandit#1096
• 3: [flake8-bandit] Implement upstream updates for S311, S324 and S605 astral-sh/ruff#10313
• 4: https://docs.python.org/3.11/library/secrets.html

---

🏁 Script executed:

head -30 test/functional/mempool_datacarrier.py

Repository: dashpay/dash

Length of output: 1014

---

🏁 Script executed:

# Search for linting configuration files
find . -maxdepth 2 -type f \( -name "ruff.toml" -o -name "pyproject.toml" -o -name ".ruff.toml" -o -name "setup.cfg" \)

Repository: dashpay/dash

Length of output: 67

---

🏁 Script executed:

# Check if there's a linting config in the root or common locations
cat pyproject.toml 2>/dev/null | grep -A 20 "\[tool.ruff\]" || echo "No ruff config in pyproject.toml or section not found"

Repository: dashpay/dash

Length of output: 109

---

🏁 Script executed:

cat ruff.toml

Repository: dashpay/dash

Length of output: 1160

---

🏁 Script executed:

# Search for other uses of randbytes in test files to verify if noqa suppression is the standard approach
rg "randbytes" test/functional/ -B 2 -A 2 | head -50

Repository: dashpay/dash

Length of output: 3425

---

Add noqa suppression comments for S311 randbytes warnings.

All five randbytes calls at lines 51-55 trigger S311 (non-cryptographic pseudo-random generator) because the linting config enforces flake8-bandit rules. Add # noqa: S311 comments to each line with a note explaining these are test-only pseudo-random initializations.

Proposed minimal fix

-        default_size_data = randbytes(MAX_OP_RETURN_RELAY - 3)
-        too_long_data = randbytes(MAX_OP_RETURN_RELAY - 2)
-        small_data = randbytes(MAX_OP_RETURN_RELAY - 4)
-        one_byte = randbytes(1)
-        zero_bytes = randbytes(0)
+        default_size_data = randbytes(MAX_OP_RETURN_RELAY - 3)  # noqa: S311 - test-only pseudo-random data
+        too_long_data = randbytes(MAX_OP_RETURN_RELAY - 2)  # noqa: S311 - test-only pseudo-random data
+        small_data = randbytes(MAX_OP_RETURN_RELAY - 4)  # noqa: S311 - test-only pseudo-random data
+        one_byte = randbytes(1)  # noqa: S311 - test-only pseudo-random data
+        zero_bytes = randbytes(0)  # noqa: S311 - test-only pseudo-random data

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	default_size_data = randbytes(MAX_OP_RETURN_RELAY - 3)
	too_long_data = randbytes(MAX_OP_RETURN_RELAY - 2)
	small_data = randbytes(MAX_OP_RETURN_RELAY - 4)
	one_byte = randbytes(1)
	zero_bytes = randbytes(0)
	default_size_data = randbytes(MAX_OP_RETURN_RELAY - 3) # noqa: S311 - test-only pseudo-random data
	too_long_data = randbytes(MAX_OP_RETURN_RELAY - 2) # noqa: S311 - test-only pseudo-random data
	small_data = randbytes(MAX_OP_RETURN_RELAY - 4) # noqa: S311 - test-only pseudo-random data
	one_byte = randbytes(1) # noqa: S311 - test-only pseudo-random data
	zero_bytes = randbytes(0) # noqa: S311 - test-only pseudo-random data

🧰 Tools

🪛 Ruff (0.15.9)

[error] 51-51: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 52-52: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 53-53: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 54-54: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 55-55: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` around lines 51 - 55, The five
test-only uses of randbytes (assignments to default_size_data, too_long_data,
small_data, one_byte, zero_bytes) trigger S311; update each line to append a
noqa suppression comment like "# noqa: S311" and include a brief inline note
such as "# test-only pseudo-random data, non-crypto" so the linter ignores these
non-cryptographic PRNG warnings while documenting intent.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check if the file exists and read the relevant section
find . -type f -name "p2p_v2_misbehaving.py" | head -5

Repository: dashpay/dash

Length of output: 95

---

🏁 Script executed:

# Read the file around line 93 to see the context
sed -n '85,100p' test/functional/p2p_v2_misbehaving.py

Repository: dashpay/dash

Length of output: 725

---

🏁 Script executed:

# Check for Ruff configuration in the project
find . -type f \( -name "ruff.toml" -o -name "pyproject.toml" -o -name ".ruff.toml" \) | head -10

Repository: dashpay/dash

Length of output: 96

---

🏁 Script executed:

# Search for other uses of randbytes in test files to see how they're handled
rg "randbytes" test/ -n

Repository: dashpay/dash

Length of output: 1417

---

🏁 Script executed:

# Check the Ruff configuration
cat ruff.toml

Repository: dashpay/dash

Length of output: 1160

---

🏁 Script executed:

# Search for existing noqa suppressions in test files for S311
rg "noqa.*S311" test/ -n

Repository: dashpay/dash

Length of output: 38

---

🏁 Script executed:

# Check if S311 is configured in pyproject.toml for src/dashbls
cat ./src/dashbls/pyproject.toml | head -50

Repository: dashpay/dash

Length of output: 249

---

🏁 Script executed:

# Check if there are per-file ignores for test/functional in ruff.toml
grep -A 10 'per-file-ignores' ruff.toml

Repository: dashpay/dash

Length of output: 135

---

Add S311 suppression comment for test-only randomness.

The random.randbytes(5) call on line 93 triggers Ruff's S311 security warning. Since this is test-only pseudo-random data for P2P protocol testing (not cryptographic use), add a suppression comment:

-        self.transport_version = random.randbytes(5)
+        self.transport_version = random.randbytes(5)  # noqa: S311

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	self.transport_version = random.randbytes(5)
	self.transport_version = random.randbytes(5) # noqa: S311

🧰 Tools

🪛 Ruff (0.15.9)

[error] 93-93: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/p2p_v2_misbehaving.py` at line 93, The test uses
non-cryptographic randomness in the assignment to self.transport_version
(random.randbytes(5)); add a Ruff S311 suppression comment on that line to
indicate this is test-only pseudo-random data (not used for crypto) so the
linter ignores it. Locate the assignment to self.transport_version and append a
comment like "# noqa: S311 -- test-only non-crypto randomness" (or equivalent
project linter suppression) to suppress the warning.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check if the file exists and read lines 601-604
head -604 test/functional/rpc_psbt.py | tail -10

Repository: dashpay/dash

Length of output: 852

---

🏁 Script executed:

# Also check surrounding context to understand the code better
sed -n '595,610p' test/functional/rpc_psbt.py

Repository: dashpay/dash

Length of output: 1241

---

🌐 Web query:

Ruff S311 linter rule insecure randomness

💡 Result:

Ruff's S311 linter rule, named "suspicious-non-cryptographic-random-usage", detects uses of cryptographically weak pseudo-random number generators like the standard 'random' module. It flags these because they are predictable and insecure for security-sensitive randomness, recommending cryptographically secure alternatives such as the 'secrets' module. Added in Ruff version 0.0.258, it originates from the flake8-bandit linter (Bandit's B311). The rule triggers on calls like random.randrange, random.randint, etc., with the message: "Standard pseudo-random generators are not suitable for cryptographic purposes." Example violation: import random random.randrange(10) Recommended fix: import secrets secrets.randbelow(10) The rule applies broadly via static analysis, as determining cryptographic context is challenging, leading to occasional false positives (e.g., non-security uses of random). It is part of Ruff's S3xx ruleset for security issues and remains active as of 2026.

Citations:

• 1: https://docs.astral.sh/ruff/rules/suspicious-non-cryptographic-random-usage/
• 2: https://docs.astral.sh/ruff/rules/
• 3: False positive S311 with random module astral-sh/ruff#13205

---

🏁 Script executed:

# Check imports in the file to see where randbytes comes from
head -100 test/functional/rpc_psbt.py | grep -E "^from|^import|randbytes"

Repository: dashpay/dash

Length of output: 476

---

🏁 Script executed:

# Search for randbytes definition or import in the file
grep -n "randbytes\|from.*import\|^import" test/functional/rpc_psbt.py | head -20

Repository: dashpay/dash

Length of output: 808

---

🏁 Script executed:

# Check what Python version is specified for this project
cat .python-version

Repository: dashpay/dash

Length of output: 63

---

🏁 Script executed:

# Check if there's a ruff configuration file or pyproject.toml with linting rules
find . -maxdepth 2 -name "pyproject.toml" -o -name "ruff.toml" -o -name ".ruff.toml" | head -5

Repository: dashpay/dash

Length of output: 67

---

🏁 Script executed:

# Look for existing ruff configurations or suppressions
grep -r "S311\|noqa" test/functional/rpc_psbt.py | head -10

Repository: dashpay/dash

Length of output: 38

---

🌐 Web query:

Python random.randbytes cryptographically secure os.urandom

💡 Result:

No, random.randbytes is not cryptographically secure. It uses the default pseudo-random number generator (Mersenne Twister) from the random module, which is unsuitable for cryptographic purposes. os.urandom is cryptographically secure. It returns random bytes from the operating system's secure randomness source (e.g., /dev/urandom on Unix, CryptGenRandom on Windows). For cryptographic random bytes, prefer: - secrets.token_bytes(n) (high-level, recommended) - os.urandom(n) (low-level) - random.SystemRandom.randbytes(n) (uses os.urandom under the hood) random.randbytes(n) explicitly warns: "This method should not be used for generating security tokens. Use secrets.token_bytes instead." (Added in Python 3.9)

Citations:

• 1: https://docs.python.org/3/library/random.html
• 2: https://docs.python.org/3.13/library/random.html
• 3: https://docs.python.org/3.14/library/random.html
• 4: https://docs.python.org/3.14/library/secrets.html
• 5: https://docs.python.org/3/library/os.html?highlight=os.urandom
• 6: https://runebook.dev/en/docs/python/library/os/os.urandom
• 7: https://www.zetcode.com/python/os-urandom/

---

🏁 Script executed:

# Check the ruff configuration to see if S311 is enabled
cat ruff.toml

Repository: dashpay/dash

Length of output: 1160

---

🏁 Script executed:

# Also check for any pyproject.toml with ruff config
cat pyproject.toml 2>/dev/null | grep -A 50 "\[tool.ruff"

Repository: dashpay/dash

Length of output: 38

---

🏁 Script executed:

# Try to run ruff on the specific lines (if ruff is available in the repo context)
# First check if ruff config includes S311
grep -i "S311\|select\|extend-select" ruff.toml

Repository: dashpay/dash

Length of output: 66

---

Add noqa: S311 comments to suppress insecure randomness warning in test code.

The randbytes() calls at lines 601-604 import from Python's random module, which Ruff's S311 rule (flake8-bandit) flags as unsuitable for cryptographic purposes. Since this is test code generating pseudo-random test data (not actual security-sensitive material), suppressing S311 with inline comments is appropriate.

Proposed minimal fix

-        hash_ripemd160, preimage_ripemd160 = randbytes(20), randbytes(50)
-        hash_sha256, preimage_sha256 = randbytes(32), randbytes(50)
-        hash_hash160, preimage_hash160 = randbytes(20), randbytes(50)
-        hash_hash256, preimage_hash256 = randbytes(32), randbytes(50)
+        hash_ripemd160, preimage_ripemd160 = randbytes(20), randbytes(50)  # noqa: S311 - test-only pseudo-random data
+        hash_sha256, preimage_sha256 = randbytes(32), randbytes(50)  # noqa: S311 - test-only pseudo-random data
+        hash_hash160, preimage_hash160 = randbytes(20), randbytes(50)  # noqa: S311 - test-only pseudo-random data
+        hash_hash256, preimage_hash256 = randbytes(32), randbytes(50)  # noqa: S311 - test-only pseudo-random data

🧰 Tools

🪛 Ruff (0.15.9)

[error] 601-601: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 601-601: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 602-602: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 602-602: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 603-603: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 603-603: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 604-604: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

[error] 604-604: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/rpc_psbt.py` around lines 601 - 604, The test uses
randbytes() to generate pseudo-random test data for variables hash_ripemd160,
preimage_ripemd160, hash_sha256, preimage_sha256, hash_hash160,
preimage_hash160, hash_hash256 and preimage_hash256; add inline suppression
comments "noqa: S311" to those randbytes() call lines to silence the insecure
randomness warning (S311) from Ruff/flake8-bandit since this is
non-cryptographic test data, keeping the calls and variable names (randbytes,
hash_ripemd160, preimage_ripemd160, etc.) unchanged.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

ruff check test/functional/test_framework/v2_p2p.py --select S311

Repository: dashpay/dash

Length of output: 2787

---

Multiple S311 violations require suppression in this file.

Lines 157, 158, and 210 all use random module functions that Ruff flags as unsuitable for cryptographic purposes. While intentional for pseudo-random test data, all occurrences need explicit suppression to avoid lint failure:

• Line 157: random.randrange()
• Line 158: random.randbytes()
• Line 210: Two calls to random.randint()

Add # noqa: S311 - test-only pseudo-random data comments to each occurrence.

🧰 Tools

🪛 Ruff (0.15.9)

[error] 158-158: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/test_framework/v2_p2p.py` at line 158, The linter flags use
of the random module as cryptographically unsafe; add inline suppressions by
appending the comment "# noqa: S311 - test-only pseudo-random data" to each
test-only pseudo-random call: the call to random.randrange(...), the assignment
using random.randbytes(garbage_len) (self.sent_garbage =
random.randbytes(garbage_len)), and the two random.randint(...) usages so each
line ends with that exact noqa comment to silence S311 for these test-only data
generators.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -u

echo "Checking wrapper header candidates:"
fd -i '^fs\.h$' src

for exclude in ":(exclude)src/util/fs.h" ":(exclude)src/fs.h"; do
  echo
  echo "=== git grep with $exclude ==="
  git grep -n "std::filesystem" -- ./src/ "$exclude"
  status=$?
  echo "exit_status=$status"
done

Repository: dashpay/dash

Length of output: 2462

---

Fix the excluded wrapper path and handle git grep exit codes explicitly.

Line 41 excludes src/util/fs.h, but the actual wrapper file is src/fs.h, causing false positives on legitimate wrapper usage.
Additionally, .status().success() on lines 43–45 conflates exit code 1 (no match) with exit code 2 (command error), silently passing when git grep fails rather than reporting the error.

Proposed fix

 fn lint_std_filesystem() -> Result<(), LintError> {
-    let found = git()
+    let out = git()
         .args([
             "grep",
             "std::filesystem",
             "--",
             "./src/",
-            ":(exclude)src/util/fs.h",
+            ":(exclude)src/fs.h",
         ])
-        .status()
-        .expect("command error")
-        .success();
-    if found {
-        Err(r#"
+        .output()
+        .expect("command error");
+
+    match out.status.code() {
+        Some(0) => Err(r#"
 ^^^
-Direct use of std::filesystem may be dangerous and buggy. Please include <util/fs.h> and use the
+Direct use of std::filesystem may be dangerous and buggy. Please include <fs.h> and use the
 fs:: namespace, which has unsafe filesystem functions marked as deleted.
             "#
-        .to_string())
-    } else {
-        Ok(())
+        .to_string()),
+        Some(1) => Ok(()), // no matches
+        _ => Err(String::from_utf8_lossy(&out.stderr).to_string()),
     }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/lint/test_runner/src/main.rs` around lines 35 - 52, The git grep
invocation in the git().args([...]) call incorrectly excludes "src/util/fs.h"
instead of the actual wrapper "src/fs.h", causing false positives, and it
blindly interprets .status().success() which treats exit code 1 (no matches)
same as exit code 2 (command error); update the args to exclude "src/fs.h" and
change the handling of the Command status produced by git().status() so you
explicitly match on the exit code or use status.code() to treat 0 as found, 1 as
not found (returning Ok/false), and any other nonzero code as an error
(returning Err with the command failure details) for the git() call used here.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (6)

test/functional/interface_rest.py (1)

67-67: ⚠️ Potential issue | 🟡 Minor

Use an explicit optional type for query_params.

Line 67 uses a non-optional type with a None default, which violates RUF013 and will fail linting.

Proposed fix

-            query_params: dict[str, typing.Any] = None,
+            query_params: dict[str, typing.Any] | None = None,

#!/bin/bash
set -euo pipefail

# Verify the exact annotation at the changed line
cat -n test/functional/interface_rest.py | sed -n '62,70p'

# Verify lint rule is configured/enforced
rg -n "RUF013|target-version|select|extend-select" ruff.toml pyproject.toml setup.cfg tox.ini 2>/dev/null || true

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/interface_rest.py` at line 67, The parameter annotation for
query_params in the function signature in test/functional/interface_rest.py is
declared as dict[str, typing.Any] with a default of None which violates RUF013;
update the annotation to an explicit optional type (e.g., use
typing.Optional[dict[str, typing.Any]] or dict[str, typing.Any] | None depending
on project Python target) and ensure the corresponding import (typing.Optional)
or syntax is present so the default None is type-correct for query_params.

src/Makefile.qt.include (1)

499-499: ⚠️ Potential issue | 🟡 Minor

Remove duplicated prerequisite in translate target.

Line 499 lists $(QT_FORMS_UI) twice. It won’t break Make, but it should be deduplicated to avoid redundant inputs to lupdate.

Suggested patch

-translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)
+translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Makefile.qt.include` at line 499, The translate target lists
$(QT_FORMS_UI) twice causing a duplicated prerequisite; edit the translate rule
(the line starting with "translate:") and remove the repeated $(QT_FORMS_UI) so
each prerequisite appears only once, ensuring the translate target and its
prerequisites (e.g., $(srcdir)/qt/dashstrings.cpp, $(QT_FORMS_UI),
$(BITCOIN_QT_BASE_CPP), $(BITCOIN_QT_WINDOWS_CPP), $(BITCOIN_QT_WALLET_CPP),
$(BITCOIN_QT_H), $(BITCOIN_MM)) are deduplicated.

test/functional/p2p_v2_misbehaving.py (1)

93-93: ⚠️ Potential issue | 🟠 Major

Suppress S311 for test-only randbytes use.

Line 93 uses non-crypto randomness in functional-test scaffolding; Ruff flags this as S311 and can fail lint unless explicitly suppressed.

Proposed fix

-        self.transport_version = random.randbytes(5)
+        self.transport_version = random.randbytes(5)  # noqa: S311 - test-only pseudo-random data

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/p2p_v2_misbehaving.py` at line 93, Suppress the S311 lint for
this test-only use of non-crypto randomness by adding an inline noqa for the
offending assignment; update the line that sets self.transport_version =
random.randbytes(5) to include a per-line suppression like `# noqa: S311` so
Ruff/linters ignore the S311 warning for the test scaffold where cryptographic
randomness isn't required.

test/functional/mempool_datacarrier.py (1)

51-55: ⚠️ Potential issue | 🟠 Major

Suppress S311 on test-only random payload fixtures.

Lines 51–55 intentionally generate pseudo-random test payloads, but Ruff S311 will keep flagging these calls.

Proposed fix

-        default_size_data = randbytes(MAX_OP_RETURN_RELAY - 3)
-        too_long_data = randbytes(MAX_OP_RETURN_RELAY - 2)
-        small_data = randbytes(MAX_OP_RETURN_RELAY - 4)
-        one_byte = randbytes(1)
-        zero_bytes = randbytes(0)
+        default_size_data = randbytes(MAX_OP_RETURN_RELAY - 3)  # noqa: S311 - test-only pseudo-random data
+        too_long_data = randbytes(MAX_OP_RETURN_RELAY - 2)  # noqa: S311 - test-only pseudo-random data
+        small_data = randbytes(MAX_OP_RETURN_RELAY - 4)  # noqa: S311 - test-only pseudo-random data
+        one_byte = randbytes(1)  # noqa: S311 - test-only pseudo-random data
+        zero_bytes = randbytes(0)  # noqa: S311 - test-only pseudo-random data

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` around lines 51 - 55, The test
generates pseudo-random payloads using randbytes (assignments default_size_data,
too_long_data, small_data, one_byte, zero_bytes) which intentionally triggers
Ruff S311; suppress this false positive by appending a per-line noqa for S311 to
each assignment (or add a file-level ruff directive if preferred), e.g. add "#
noqa: S311" to the lines creating these fixtures so the linter ignores these
test-only random bytes.

test/functional/test_framework/v2_p2p.py (1)

158-158: ⚠️ Potential issue | 🟠 Major

Add inline S311 suppression for handshake garbage generation.

Line 158 is test-only pseudo-random data generation, but Ruff still flags it as S311.

Proposed fix

-        self.sent_garbage = random.randbytes(garbage_len)
+        self.sent_garbage = random.randbytes(garbage_len)  # noqa: S311 - test-only pseudo-random data

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/test_framework/v2_p2p.py` at line 158, Ruff flags the
test-only pseudo-random data generation as S311; suppress it inline by adding a
per-line noqa for S311 to the assignment to self.sent_garbage (the call to
random.randbytes(garbage_len)) — append "# noqa: S311" to that line so the test
remains unchanged but the linter no longer reports S311 for this intentional
test-only random byte generation.

test/functional/rpc_psbt.py (1)

601-604: ⚠️ Potential issue | 🟠 Major

Add S311 suppression to PSBT preimage/hash random fixtures.

Lines 601–604 are test-only random byte fixtures; Ruff flags each randbytes() call as S311.

Proposed fix

-        hash_ripemd160, preimage_ripemd160 = randbytes(20), randbytes(50)
-        hash_sha256, preimage_sha256 = randbytes(32), randbytes(50)
-        hash_hash160, preimage_hash160 = randbytes(20), randbytes(50)
-        hash_hash256, preimage_hash256 = randbytes(32), randbytes(50)
+        hash_ripemd160, preimage_ripemd160 = randbytes(20), randbytes(50)  # noqa: S311 - test-only pseudo-random data
+        hash_sha256, preimage_sha256 = randbytes(32), randbytes(50)  # noqa: S311 - test-only pseudo-random data
+        hash_hash160, preimage_hash160 = randbytes(20), randbytes(50)  # noqa: S311 - test-only pseudo-random data
+        hash_hash256, preimage_hash256 = randbytes(32), randbytes(50)  # noqa: S311 - test-only pseudo-random data

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/rpc_psbt.py` around lines 601 - 604, The test-only random
byte fixtures (variables hash_ripemd160, preimage_ripemd160, hash_sha256,
preimage_sha256, hash_hash160, preimage_hash160, hash_hash256, preimage_hash256
in rpc_psbt.py) are triggering Ruff S311; silence it by adding a per-expression
suppression, e.g. append "# noqa: S311" to each randbytes(...) call or add a
single inline ruff noqa that covers those assignments so the test remains
unchanged but Ruff no longer flags the lines.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/functional/p2p_net_deadlock.py`:
- Line 21: The test uses non-cryptographic random generation via randbytes to
create protocol payloads (rand_msg =
randbytes(MAX_PROTOCOL_MESSAGE_LENGTH).hex()), which triggers Ruff S311;
suppress this warning for the test-only usage by adding a per-line exemption
such as appending "# noqa: S311" to the rand_msg line (or an equivalent ruff
noqa comment referencing S311) so Ruff ignores this security rule for that
specific test-only pseudo-random payload generation.

---

Duplicate comments:
In `@src/Makefile.qt.include`:
- Line 499: The translate target lists $(QT_FORMS_UI) twice causing a duplicated
prerequisite; edit the translate rule (the line starting with "translate:") and
remove the repeated $(QT_FORMS_UI) so each prerequisite appears only once,
ensuring the translate target and its prerequisites (e.g.,
$(srcdir)/qt/dashstrings.cpp, $(QT_FORMS_UI), $(BITCOIN_QT_BASE_CPP),
$(BITCOIN_QT_WINDOWS_CPP), $(BITCOIN_QT_WALLET_CPP), $(BITCOIN_QT_H),
$(BITCOIN_MM)) are deduplicated.

In `@test/functional/interface_rest.py`:
- Line 67: The parameter annotation for query_params in the function signature
in test/functional/interface_rest.py is declared as dict[str, typing.Any] with a
default of None which violates RUF013; update the annotation to an explicit
optional type (e.g., use typing.Optional[dict[str, typing.Any]] or dict[str,
typing.Any] | None depending on project Python target) and ensure the
corresponding import (typing.Optional) or syntax is present so the default None
is type-correct for query_params.

In `@test/functional/mempool_datacarrier.py`:
- Around line 51-55: The test generates pseudo-random payloads using randbytes
(assignments default_size_data, too_long_data, small_data, one_byte, zero_bytes)
which intentionally triggers Ruff S311; suppress this false positive by
appending a per-line noqa for S311 to each assignment (or add a file-level ruff
directive if preferred), e.g. add "# noqa: S311" to the lines creating these
fixtures so the linter ignores these test-only random bytes.

In `@test/functional/p2p_v2_misbehaving.py`:
- Line 93: Suppress the S311 lint for this test-only use of non-crypto
randomness by adding an inline noqa for the offending assignment; update the
line that sets self.transport_version = random.randbytes(5) to include a
per-line suppression like `# noqa: S311` so Ruff/linters ignore the S311 warning
for the test scaffold where cryptographic randomness isn't required.

In `@test/functional/rpc_psbt.py`:
- Around line 601-604: The test-only random byte fixtures (variables
hash_ripemd160, preimage_ripemd160, hash_sha256, preimage_sha256, hash_hash160,
preimage_hash160, hash_hash256, preimage_hash256 in rpc_psbt.py) are triggering
Ruff S311; silence it by adding a per-expression suppression, e.g. append "#
noqa: S311" to each randbytes(...) call or add a single inline ruff noqa that
covers those assignments so the test remains unchanged but Ruff no longer flags
the lines.

In `@test/functional/test_framework/v2_p2p.py`:
- Line 158: Ruff flags the test-only pseudo-random data generation as S311;
suppress it inline by adding a per-line noqa for S311 to the assignment to
self.sent_garbage (the call to random.randbytes(garbage_len)) — append "# noqa:
S311" to that line so the test remains unchanged but the linter no longer
reports S311 for this intentional test-only random byte generation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0ce535bc-9487-43e4-a8af-990c97886c46

📥 Commits

Reviewing files that changed from the base of the PR and between 659d7c7 and 63494e8.

⛔ Files ignored due to path filters (1)

• test/lint/test_runner/Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (38)

• Makefile.am
• ci/lint/04_install.sh
• ci/lint/06_script.sh
• ci/lint/docker-entrypoint.sh
• ci/test/00_setup_env_native_fuzz.sh
• contrib/devtools/circular-dependencies.py
• contrib/devtools/utils.py
• contrib/guix/security-check.py
• contrib/guix/symbol-check.py
• contrib/macdeploy/macdeployqtplus
• contrib/message-capture/message-capture-parser.py
• contrib/seeds/makeseeds.py
• src/.clang-tidy
• src/Makefile.qt.include
• src/fs.h
• src/test/util/script.h
• src/wallet/db.cpp
• src/wallet/transaction.cpp
• src/wallet/transaction.h
• src/wallet/wallet.cpp
• src/wallet/wallet.h
• test/functional/interface_rest.py
• test/functional/mempool_datacarrier.py
• test/functional/p2p_net_deadlock.py
• test/functional/p2p_v2_misbehaving.py
• test/functional/rpc_psbt.py
• test/functional/test_framework/script.py
• test/functional/test_framework/test_framework.py
• test/functional/test_framework/util.py
• test/functional/test_framework/v2_p2p.py
• test/functional/test_framework/wallet.py
• test/functional/wallet_fast_rescan.py
• test/fuzz/test_runner.py
• test/lint/README.md
• test/lint/lint-files.py
• test/lint/lint-include-guards.py
• test/lint/test_runner/Cargo.toml
• test/lint/test_runner/src/main.rs

✅ Files skipped from review due to trivial changes (20)

• contrib/devtools/circular-dependencies.py
• test/functional/test_framework/script.py
• contrib/guix/security-check.py
• src/fs.h
• src/.clang-tidy
• ci/test/00_setup_env_native_fuzz.sh
• test/lint/test_runner/Cargo.toml
• contrib/devtools/utils.py
• test/lint/lint-files.py
• src/wallet/wallet.h
• test/functional/test_framework/wallet.py
• test/functional/wallet_fast_rescan.py
• src/test/util/script.h
• contrib/guix/symbol-check.py
• contrib/message-capture/message-capture-parser.py
• contrib/macdeploy/macdeployqtplus
• test/lint/lint-include-guards.py
• test/lint/README.md
• contrib/seeds/makeseeds.py
• test/functional/test_framework/test_framework.py

🚧 Files skipped from review as they are similar to previous changes (7)

• ci/lint/docker-entrypoint.sh
• ci/lint/06_script.sh
• test/functional/test_framework/util.py
• ci/lint/04_install.sh
• test/fuzz/test_runner.py
• Makefile.am
• test/lint/test_runner/src/main.rs

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Find and examine the file
find . -path "*/test/functional/p2p_net_deadlock.py" -type f

Repository: dashpay/dash

Length of output: 93

---

🏁 Script executed:

# Check for Ruff configuration files
find . -maxdepth 3 -type f \( -name "pyproject.toml" -o -name "ruff.toml" -o -name ".flake8" -o -name "setup.cfg" \) | head -10

Repository: dashpay/dash

Length of output: 118

---

🏁 Script executed:

# Search for S311 references in the codebase to understand how it's configured
rg "S311|noqa.*S311" --type py | head -20

Repository: dashpay/dash

Length of output: 38

---

🏁 Script executed:

# Examine the file around line 21
sed -n '1,30p' ./test/functional/p2p_net_deadlock.py | cat -n

Repository: dashpay/dash

Length of output: 1308

---

🏁 Script executed:

# Check the imports at the top of the file
head -30 ./test/functional/p2p_net_deadlock.py

Repository: dashpay/dash

Length of output: 1098

---

🏁 Script executed:

# Read the ruff.toml configuration
cat ./ruff.toml

Repository: dashpay/dash

Length of output: 1160

---

Add S311 security rule exemption for test-only pseudo-random payload generation.

Line 21 uses randbytes from the random module (non-cryptographic), which Ruff S311 flags. Since this is test-only payload generation for protocol messages, the suppression is appropriate.

Proposed fix

-        rand_msg = randbytes(MAX_PROTOCOL_MESSAGE_LENGTH).hex()
+        rand_msg = randbytes(MAX_PROTOCOL_MESSAGE_LENGTH).hex()  # noqa: S311 - test-only pseudo-random data

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	rand_msg = randbytes(MAX_PROTOCOL_MESSAGE_LENGTH).hex()
	rand_msg = randbytes(MAX_PROTOCOL_MESSAGE_LENGTH).hex() # noqa: S311 - test-only pseudo-random data

🧰 Tools

🪛 Ruff (0.15.9)

[error] 21-21: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/p2p_net_deadlock.py` at line 21, The test uses
non-cryptographic random generation via randbytes to create protocol payloads
(rand_msg = randbytes(MAX_PROTOCOL_MESSAGE_LENGTH).hex()), which triggers Ruff
S311; suppress this warning for the test-only usage by adding a per-line
exemption such as appending "# noqa: S311" to the rand_msg line (or an
equivalent ruff noqa comment referencing S311) so Ruff ignores this security
rule for that specific test-only pseudo-random payload generation.

[thepastaclaw]

Code Review

Validated the full PR range against upstream/develop...HEAD. One blocking finding is actionable: the new Rust lint runner is wired into CI and currently fails in this tree because it excludes Bitcoin Core's src/util/fs.h instead of Dash's src/fs.h. The indentation note is not review-worthy, and the src/validation.cpp item is out of scope.

Reviewed commit: 63494e8

🔴 1 blocking

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `test/lint/test_runner/src/main.rs`:
- [BLOCKING] line 41: Rust lint runner excludes the wrong filesystem wrapper header for Dash
  This new lint is now executed by `ci/lint/06_script.sh`, but the pathspec still excludes `src/util/fs.h`, which does not exist in this tree. Dash's wrapper lives at `src/fs.h`, so `git grep "std::filesystem" -- ./src/ ':(exclude)src/util/fs.h'` still matches the intentional `std::filesystem` usages in `src/fs.h` and makes the lint fail every time. I reproduced this by running `cargo run` from `test/lint/test_runner/`, which exits with the `std::filesystem check` failure in this checkout. Please exclude `src/fs.h` here so lint CI can pass.

[thepastaclaw]

🔴 Blocking: Rust lint runner excludes the wrong filesystem wrapper header for Dash

This new lint is now executed by ci/lint/06_script.sh, but the pathspec still excludes src/util/fs.h, which does not exist in this tree. Dash's wrapper lives at src/fs.h, so git grep "std::filesystem" -- ./src/ ':(exclude)src/util/fs.h' still matches the intentional std::filesystem usages in src/fs.h and makes the lint fail every time. I reproduced this by running cargo run from test/lint/test_runner/, which exits with the std::filesystem check failure in this checkout. Please exclude src/fs.h here so lint CI can pass.

💡 Suggested change

Suggested change

	":(exclude)src/util/fs.h",
	:(exclude)src/fs.h

_{source: ['claude-general']}

🤖 Fix this with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `test/lint/test_runner/src/main.rs`:
- [BLOCKING] line 41: Rust lint runner excludes the wrong filesystem wrapper header for Dash
  This new lint is now executed by `ci/lint/06_script.sh`, but the pathspec still excludes `src/util/fs.h`, which does not exist in this tree. Dash's wrapper lives at `src/fs.h`, so `git grep "std::filesystem" -- ./src/ ':(exclude)src/util/fs.h'` still matches the intentional `std::filesystem` usages in `src/fs.h` and makes the lint fail every time. I reproduced this by running `cargo run` from `test/lint/test_runner/`, which exits with the `std::filesystem check` failure in this checkout. Please exclude `src/fs.h` here so lint CI can pass.