backport: Merge bitcoin#27005, 28644, 26940, 27511, 28403, 28361, 28409, 28352

[vijaydasmp]

bitcoin backports

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[thepastaclaw]

Review Gate

Commit: a0405291

• ⏳ Debounce: 16m ago (need 30m)

• ⏳ CI checks: checks still running (9 pending)

• ✅ CodeRabbit review: comment found

• ✅ Off-peak hours: off-peak (08:09 PM PT Friday)

• Run review now (check to override)

[coderabbitai]

Walkthrough

This pull request primarily reorganizes test infrastructure and introduces a new RPC command. It moves random utility functions from setup_common.h to a dedicated test/util/random.h header and updates ~40 test files to include this header. A new test/util/coins.cpp utility file is created for generating test coins. The Timer implementation switches from default-initialized microseconds to optional steady_clock timestamps. A new hidden RPC command getaddrmaninfo is added to expose address manager statistics. The P2P test framework's sync method is simplified by consolidating sync_send_with_ping() into sync_with_ping(). Wallet functional tests have unlock timeout values increased from short durations to 999000 seconds. Minor improvements include fuzzing enhancements for public key construction and platform detection updates.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Suggested reviewers

• UdjinM6

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 2.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately summarizes the core objective: merging multiple bitcoin backports (PR numbers listed) into the develop branch.
Description check	✅ Passed	The PR description 'bitcoin backports' is minimal but directly related to the changeset, which exclusively contains backported changes from bitcoin/bitcoin.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

test/functional/p2p_ibd_stalling.py (1)

161-164: Consider renaming the helper for clarity.

The method now calls sync_with_ping(), so all_sync_send_with_ping is slightly misleading. A rename would reduce cognitive overhead in this test.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/p2p_ibd_stalling.py` around lines 161 - 164, Rename the
helper function all_sync_send_with_ping to a clearer name that reflects it calls
each peer's sync_with_ping method (e.g., sync_all_with_ping or
peers_sync_with_ping); update the function definition (all_sync_send_with_ping)
and every call site to the new name, and ensure any tests or imports referencing
the old name are adjusted so behavior remains identical and no references remain
to all_sync_send_with_ping.

src/test/fuzz/util.cpp (1)

319-329: Guard against short byte_data spans in ConstructPubKeyBytes.

This helper assumes at least 33/65 bytes and does unchecked iterator arithmetic. Adding a precondition assert makes the function safer for future reuse.

♻️ Proposed hardening

 std::vector<uint8_t> ConstructPubKeyBytes(FuzzedDataProvider& fuzzed_data_provider, Span<const uint8_t> byte_data, const bool compressed) noexcept
 {
+    const size_t needed = compressed ? CPubKey::COMPRESSED_SIZE : CPubKey::SIZE;
+    assert(byte_data.size() >= needed);
     uint8_t pk_type;
     if (compressed) {
         pk_type = fuzzed_data_provider.PickValueInArray({0x02, 0x03});
     } else {
         pk_type = fuzzed_data_provider.PickValueInArray({0x04, 0x06, 0x07});
     }
-    std::vector<uint8_t> pk_data{byte_data.begin(), byte_data.begin() + (compressed ? CPubKey::COMPRESSED_SIZE : CPubKey::SIZE)};
+    std::vector<uint8_t> pk_data{byte_data.begin(), byte_data.begin() + needed};
     pk_data[0] = pk_type;
     return pk_data;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/test/fuzz/util.cpp` around lines 319 - 329, ConstructPubKeyBytes assumes
byte_data has at least CPubKey::COMPRESSED_SIZE or CPubKey::SIZE bytes; add a
guard at the start of ConstructPubKeyBytes that checks byte_data.size() >=
(compressed ? CPubKey::COMPRESSED_SIZE : CPubKey::SIZE) and assert or return an
empty/std::vector<uint8_t>() if the precondition fails, then proceed to
PickValueInArray and slice using the validated size (referencing
ConstructPubKeyBytes, fuzzed_data_provider, CPubKey::COMPRESSED_SIZE,
CPubKey::SIZE).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/get_previous_releases.py`:
- Around line 267-270: The platforms mapping added an entry for
'powerpc64le-*-linux-*' -> 'powerpc64le-linux-gnu' but there are no
corresponding SHA256_SUMS entries and download_binary() rejects tarballs without
checksum entries; either revert/remove the 'powerpc64le-*-linux-*' entry from
the platforms dict (so host detection keeps it unmapped) or add the official
Dash release assets and matching checksum lines for 'powerpc64le-linux-gnu' into
the SHA256_SUMS data used by download_binary() and ensure the checksum keys
match exactly the platform string; update the SHA256_SUMS source and test
download_binary() to accept those checksums if you choose to add support.

---

Nitpick comments:
In `@src/test/fuzz/util.cpp`:
- Around line 319-329: ConstructPubKeyBytes assumes byte_data has at least
CPubKey::COMPRESSED_SIZE or CPubKey::SIZE bytes; add a guard at the start of
ConstructPubKeyBytes that checks byte_data.size() >= (compressed ?
CPubKey::COMPRESSED_SIZE : CPubKey::SIZE) and assert or return an
empty/std::vector<uint8_t>() if the precondition fails, then proceed to
PickValueInArray and slice using the validated size (referencing
ConstructPubKeyBytes, fuzzed_data_provider, CPubKey::COMPRESSED_SIZE,
CPubKey::SIZE).

In `@test/functional/p2p_ibd_stalling.py`:
- Around line 161-164: Rename the helper function all_sync_send_with_ping to a
clearer name that reflects it calls each peer's sync_with_ping method (e.g.,
sync_all_with_ping or peers_sync_with_ping); update the function definition
(all_sync_send_with_ping) and every call site to the new name, and ensure any
tests or imports referencing the old name are adjusted so behavior remains
identical and no references remain to all_sync_send_with_ping.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 600d104e-11b6-4612-9e78-a9f8b7ab2e16

📥 Commits

Reviewing files that changed from the base of the PR and between 56bceb4 and a040529.

📒 Files selected for processing (62)

• src/Makefile.test_util.include
• src/logging/timer.h
• src/rpc/net.cpp
• src/test/base58_tests.cpp
• src/test/bip324_tests.cpp
• src/test/blockencodings_tests.cpp
• src/test/bloom_tests.cpp
• src/test/checkqueue_tests.cpp
• src/test/coins_tests.cpp
• src/test/crypto_tests.cpp
• src/test/cuckoocache_tests.cpp
• src/test/dbwrapper_tests.cpp
• src/test/fuzz/rpc.cpp
• src/test/fuzz/util.cpp
• src/test/hash_tests.cpp
• src/test/key_tests.cpp
• src/test/logging_tests.cpp
• src/test/merkle_tests.cpp
• src/test/miner_tests.cpp
• src/test/minisketch_tests.cpp
• src/test/net_tests.cpp
• src/test/orphanage_tests.cpp
• src/test/pmt_tests.cpp
• src/test/pool_tests.cpp
• src/test/pow_tests.cpp
• src/test/prevector_tests.cpp
• src/test/script_tests.cpp
• src/test/serfloat_tests.cpp
• src/test/sighash_tests.cpp
• src/test/skiplist_tests.cpp
• src/test/streams_tests.cpp
• src/test/transaction_tests.cpp
• src/test/txpackage_tests.cpp
• src/test/util/blockfilter.cpp
• src/test/util/coins.cpp
• src/test/util/coins.h
• src/test/util/llmq_tests.h
• src/test/util/random.h
• src/test/util/setup_common.h
• src/test/util_tests.cpp
• src/test/validation_block_tests.cpp
• src/test/validation_chainstate_tests.cpp
• src/test/validation_chainstatemanager_tests.cpp
• src/test/validation_flush_tests.cpp
• src/test/versionbits_tests.cpp
• src/wallet/test/wallet_crypto_tests.cpp
• test/functional/p2p_addrfetch.py
• test/functional/p2p_blocksonly.py
• test/functional/p2p_compactblocks_blocksonly.py
• test/functional/p2p_filter.py
• test/functional/p2p_ibd_stalling.py
• test/functional/p2p_ibd_txrelay.py
• test/functional/rpc_net.py
• test/functional/test_framework/p2p.py
• test/functional/wallet_createwallet.py
• test/functional/wallet_descriptor.py
• test/functional/wallet_dump.py
• test/functional/wallet_encryption.py
• test/functional/wallet_fundrawtransaction.py
• test/functional/wallet_keypool.py
• test/fuzz/test_runner.py
• test/get_previous_releases.py

💤 Files with no reviewable changes (2)

• src/test/util/blockfilter.cpp
• src/test/util/setup_common.h

[coderabbitai]

⚠️ Potential issue | 🟠 Major

powerpc64le now passes host detection but still can't download any Dash release.

Line 269 enables the platform, but this file still has no powerpc64le-linux-gnu entries in SHA256_SUMS, and download_binary() rejects tarballs without a matching checksum entry. On a powerpc64le host this now gets past detection only to fail later for every default tag. Please either add the matching release assets/checksums or keep the host unmapped until Dash publishes supported binaries.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/get_previous_releases.py` around lines 267 - 270, The platforms mapping
added an entry for 'powerpc64le-*-linux-*' -> 'powerpc64le-linux-gnu' but there
are no corresponding SHA256_SUMS entries and download_binary() rejects tarballs
without checksum entries; either revert/remove the 'powerpc64le-*-linux-*' entry
from the platforms dict (so host detection keeps it unmapped) or add the
official Dash release assets and matching checksum lines for
'powerpc64le-linux-gnu' into the SHA256_SUMS data used by download_binary() and
ensure the checksum keys match exactly the platform string; update the
SHA256_SUMS source and test download_binary() to accept those checksums if you
choose to add support.