Adds support for slice query parameters using ParamWrapper types#998
Open
sharonjl wants to merge 3 commits intodanielgtaylor:mainfrom
Open
Adds support for slice query parameters using ParamWrapper types#998sharonjl wants to merge 3 commits intodanielgtaylor:mainfrom
sharonjl wants to merge 3 commits intodanielgtaylor:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 93.13% 93.06% -0.07%
==========================================
Files 23 23
Lines 4777 4801 +24
==========================================
+ Hits 4449 4468 +19
- Misses 269 272 +3
- Partials 59 61 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for slice query parameters using
ParamWrappertypes (e.g.,[]OptionalParam[int]). Previously,parseSliceIntoonly handled primitive slice element kinds. Struct elements implementingParamWrapperwerereturned as
errUnparsable.Changes
parseArrStructElementhelper that unwraps each slice element'sParamWrapper.Receiver()anddelegates per-element parsing to
parseInto, supporting all receiver types includingtime.Time,url.URL,and
TextUnmarshalercase reflect.StructtoparseSliceIntoswitch forParamWrapper-implementing struct elementsctxandparamFieldInfothroughparseSliceIntoso the struct case can callparseIntodirectlyParamReactor.OnParamSetis called per element when implemented, with the unwrapped parsed value matchingscalar behavior
I am a little unsure of the reflect unwrapping but there doesn't seem to be another approach other than implementing TextMarshal/Unmarshal to support slice query params of type struct.