Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 92.54% 92.62% +0.07%
==========================================
Files 23 23
Lines 4481 4499 +18
==========================================
+ Hits 4147 4167 +20
+ Misses 275 274 -1
+ Partials 59 58 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
findHeadersfunc ignored structs as headers were intended to only be set at the top-level of the output struct. This worked; however, there was a subtle bug within_findInTypethat meant this was ignored if a field was a struct slice (or array, or map) rather than just a single struct.This introduced various issues, namely the documentation and setting of headers from struct slices, which was particularly problematic for
[]*http.Cookie. This fix adjusts the struct type detection to automatically detect arrays, maps, and slices and check their root type.This PR also implements support for hidden headers (nested or otherwise) from the generated OpenAPI documentation.
This PR:
[]http.Cookieis wrong #776 by not setting headers based on struct slice fieldsI created this as an improved and simplified version of #943 which doesn't require recursive field resolution. This means it doesn't close as many issues as it doesn't implement new functionality, but does resolve a few bugs.