[BUG] danger.gitlab.mr.description can be null

[xaverlutz]

Describe the bug
danger.gitlab.mr.description is null if no description was set in the request body when the MR was generated via the GitLab API.

Steps to reproduce

1. Create an MR in GitLab with the API
2. Check for includes in the description

Expected behavior
The description should always be an empty string.

Screenshots

Your Environment

software	version
danger.js	11.3.1
node	v20.11.1
npm	10.2.4
Operating System	macOS 14.3.1 (23D60)

Additional context

[mobinyardim]

I’m seeing the same issue. @fbartho, if you agree, I’d be happy to create a PR to fix this!

Error: TypeError: Cannot read properties of null (reading 'includes')
at checkSecurityVulnerabilities (...)
at process processTicksAndRejections (node: internal/process/task_queues:105:5)
at async dangerPipe (...)

[mobinyardim]

I’ve identified a crash occurring when a GitLab Merge Request has no description (common when created via IntelliJ). The issue stems from the upstream @gitbeaker/rest package, where the description field in CondensedMergeRequestSchema is strictly typed as a string but receives null from the API.

I have opened an issue with the Gitbeaker maintainers here: issue #3823

Once resolved there, a dependency bump may be needed here to prevent this crash for Danger users on GitLab.

[glensc]

gitbeaker 43 is needed:

• fix: allow null description in CondensedMergeRequestSchema jdalrymple/gitbeaker#3823 (comment)

I started something, but didn't reach far:

• Chore: Upgrade GitBeaker dependency to 43.8.0 #1510