This repository was archived by the owner on Apr 26, 2021. It is now read-only.
Fix Regular Expression injection#3188
Open
jorgectf wants to merge 2 commits intocuckoosandbox:masterfrom
jorgectf:fix-regex-injection
Open
Fix Regular Expression injection#3188jorgectf wants to merge 2 commits intocuckoosandbox:masterfrom jorgectf:fix-regex-injection
jorgectf wants to merge 2 commits intocuckoosandbox:masterfrom
jorgectf:fix-regex-injection
Conversation
1 task
Author
|
@botherder @jbremer @jekil @rep Sorry for the ping! Could you merge this? Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fact of not sanitizing user input appended to a regular expression may lead to a
Regular Expression Denial of Serviceby an attacker crafting a regular expression taking too much to load, or simply change the behaviour of the program.Vulnerable code:
cuckoo/cuckoo/web/analysis/views.py
Line 141 in 073c5aa
References:
OWASP ReDoS