Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts a broad “AWX Operator” → “Ascender Operator” rebrand across documentation, Ansible role metadata, release/publishing scripts, and local development tooling, while keeping the AWX CRDs intact.
Changes:
- Updates many docs/READMEs and Ansible Galaxy role metadata to use “Ascender Operator” and the
ctrliq/ascender-operatorrepo URLs. - Adjusts build/test/support tooling references (Makefile, mkdocs, molecule, nox, publish script) toward the new operator branding and image locations.
- Adds a new OLM ClusterServiceVersion base manifest for
ascender-operator.
Reviewed changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/restore/README.md | Updates restore role requirements branding. |
| roles/restore/meta/main.yml | Updates role metadata description branding. |
| roles/installer/meta/main.yml | Updates role metadata description branding. |
| roles/common/meta/main.yml | Updates role metadata description branding. |
| roles/backup/README.md | Updates backup role requirements branding. |
| roles/backup/meta/main.yml | Updates role metadata description branding. |
| README.md | Renames project title/links and adjusts “Get Involved” text. |
| PROJECT | Renames operator-sdk project name. |
| noxfile.py | Updates doc build docstring branding. |
| molecule/kind/molecule.yml | Updates molecule debug output directory naming. |
| molecule/default/tasks/awx_test.yml | Updates messaging around release env var branding. |
| molecule/default/molecule.yml | Updates molecule debug output directory naming. |
| mkdocs.yml | Updates site/repo branding settings. |
| Makefile | Updates chart naming and namespace default (currently problematic). |
| hack/publish-to-operator-hub.sh | Updates operatorhub publishing script for new image/repo names. |
| docs/user-guide/network-and-tls-configuration.md | Branding updates in user guide. |
| docs/user-guide/database-configuration.md | Branding updates in user guide. |
| docs/user-guide/advanced-configuration/trusting-a-custom-certificate-authority.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/persisting-projects-directory.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/mesh-ingress.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/extra-settings.md | Branding updates in advanced config docs. |
| docs/user-guide/advanced-configuration/custom-receptor-certs.md | Branding updates in advanced config docs. |
| docs/troubleshooting/debugging.md | Branding updates (currently mismatched with manifests). |
| docs/requirements.in | Branding update in docs requirements comment. |
| docs/README.md | Branding updates in docs build instructions. |
| docs/installation/kind-install.md | Branding updates in kind install instructions. |
| docs/installation/index.md | Branding updates in installation index. |
| docs/installation/basic-install.md | Branding updates in basic install steps/output (currently mismatched with manifests). |
| docs/index.md | Branding updates on docs landing page. |
| docs/contributors-guide/release-process.md | Branding updates in contributor docs. |
| docs/contributors-guide/get-involved.md | Updates contributor “Get involved” contact info. |
| docs/contributors-guide/contributing.md | Updates contributor guide repo links. |
| CONTRIBUTING.md | Branding updates in contributing guidelines. |
| config/manifests/bases/ascender-operator.clusterserviceversion.yaml | Adds new CSV base (currently inconsistent/likely non-functional). |
| CHANGELOG.md | Branding update but also removes older changelog content. |
| ascendermeshingress-demo.yml | Renames demo values (currently invalid K8s names). |
| ascender-demo.yml | Renames demo values (currently invalid K8s names). |
| ansible/instantiate-awx-deployment.yml | Branding update in playbook title. |
| ansible/helm-release.yml | Updates chart repo/name references. |
| .yamllint | Updates yamllint ignore entry for renamed CSV. |
| .helm/starter/README.md | Branding updates in Helm starter documentation. |
Comments suppressed due to low confidence (3)
ascender-demo.yml:5
metadata.namemust be a valid Kubernetes resource name (DNS-1123); capital letters are not allowed, so this example manifest will be rejected by the API server.
ascendermeshingress-demo.yml:7- Both
metadata.nameandspec.deployment_nameshould be valid Kubernetes-style names; the current values contain capital letters and will not work reliably (anddeployment_nameshould match the AWX object name used elsewhere).
CHANGELOG.md:11 - This change removes the historical changelog entries after
0.19.0(e.g., older release notes). Given the PR description is focused on rebranding, this looks like an accidental truncation rather than an intentional branding update.
# 0.19.0 (Mar 23, 2022)
- Fix corrupted spec for the service with nodeport type (kurokobo) - dbaf64e
- Add ability to deploy with OLM & added logo (Christian Adams) - 86c31a4
- Fix backup & restore issues with special characters in the postgres password (kurokobo) - 589a375
- Use centos:stream8 container where applicable (Shane McDonald)- 12a58d7
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 41 changed files in this pull request and generated 12 comments.
Comments suppressed due to low confidence (1)
CHANGELOG.md:7
- This PR removes all changelog entries prior to 0.19.0. That’s a significant content change unrelated to branding and will make it harder to audit historical behavior across releases—was this truncation intentional for the fork?
This is a list of high-level changes for each release of `ascender-operator`. A full list of commits can be found at `https://github.com/ctrliq/ascender-operator/releases/tag/<version>`.
# 0.19.0 (Mar 23, 2022)
- Fix corrupted spec for the service with nodeport type (kurokobo) - dbaf64e
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 52 out of 53 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
CHANGELOG.md:7
- This change truncates the changelog to only include 0.19.0 and removes all older release notes. A branding-only PR shouldn't drop historical release information; please restore the previously documented versions (or move them elsewhere) so the changelog remains complete.
This is a list of high-level changes for each release of `ascender-operator`. A full list of commits can be found at `https://github.com/ctrliq/ascender-operator/releases/tag/<version>`.
# 0.19.0 (Mar 23, 2022)
- Fix corrupted spec for the service with nodeport type (kurokobo) - dbaf64e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick stab at fixing the branding to Ascender without creating breaking changes within the CRD.