[Mirror] MueLu: Fix setting 'repartition: use subcommunicators' in MultiPhys#99
[Mirror] MueLu: Fix setting 'repartition: use subcommunicators' in MultiPhys#99
Conversation
Signed-off-by: malphil <malphil@sandia.gov>
|
CDash for AT1 results [Only accessible from Sandia networks] |
There was a problem hiding this comment.
Code Review
This pull request updates the MultiPhys operator in MueLu to correctly retrieve the boolean value of the 'repartition: use subcommunicators' parameter instead of using its existence check as the value. A review comment suggests wrapping the updated line to improve readability and comply with line length standards.
|
|
||
| if (paramListMultiphysics_->isParameter("repartition: use subcommunicators")) | ||
| arrayOfParamLists_[iii]->set("repartition: use subcommunicators", paramListMultiphysics_->isParameter("repartition: use subcommunicators")); | ||
| arrayOfParamLists_[iii]->set("repartition: use subcommunicators", paramListMultiphysics_->get<bool>("repartition: use subcommunicators")); |
There was a problem hiding this comment.
This line is quite long (approximately 130 characters) and performs a redundant lookup of the parameter 'repartition: use subcommunicators' which was already checked in the preceding if statement. Consider wrapping the line for better readability and to adhere to standard line length limits.
| arrayOfParamLists_[iii]->set("repartition: use subcommunicators", paramListMultiphysics_->get<bool>("repartition: use subcommunicators")); | |
| arrayOfParamLists_[iii]->set("repartition: use subcommunicators", | |
| paramListMultiphysics_->get<bool>("repartition: use subcommunicators")); |
Automated mirror of upstream PR trilinos#15178 @trilinos/muelu