Skip to content

[Mirror] MueLu: Fix setting 'repartition: use subcommunicators' in MultiPhys#99

Open
csiefer2 wants to merge 1 commit intodevelopfrom
pr-mirror-15178
Open

[Mirror] MueLu: Fix setting 'repartition: use subcommunicators' in MultiPhys#99
csiefer2 wants to merge 1 commit intodevelopfrom
pr-mirror-15178

Conversation

@csiefer2
Copy link
Copy Markdown
Owner

Automated mirror of upstream PR trilinos#15178 @trilinos/muelu

Signed-off-by: malphil <malphil@sandia.gov>
@github-actions
Copy link
Copy Markdown

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MultiPhys operator in MueLu to correctly retrieve the boolean value of the 'repartition: use subcommunicators' parameter instead of using its existence check as the value. A review comment suggests wrapping the updated line to improve readability and comply with line length standards.


if (paramListMultiphysics_->isParameter("repartition: use subcommunicators"))
arrayOfParamLists_[iii]->set("repartition: use subcommunicators", paramListMultiphysics_->isParameter("repartition: use subcommunicators"));
arrayOfParamLists_[iii]->set("repartition: use subcommunicators", paramListMultiphysics_->get<bool>("repartition: use subcommunicators"));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line is quite long (approximately 130 characters) and performs a redundant lookup of the parameter 'repartition: use subcommunicators' which was already checked in the preceding if statement. Consider wrapping the line for better readability and to adhere to standard line length limits.

Suggested change
arrayOfParamLists_[iii]->set("repartition: use subcommunicators", paramListMultiphysics_->get<bool>("repartition: use subcommunicators"));
arrayOfParamLists_[iii]->set("repartition: use subcommunicators",
paramListMultiphysics_->get<bool>("repartition: use subcommunicators"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants