Conversation
|
CDash for AT1 results [Only accessible from Sandia networks] |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the CMakeLists.txt file to conditionally include Thyra-related headers based on the ${PACKAGE_NAME}_ENABLE_Thyra flag. The review feedback recommends also moving Stratimikos-related headers and the corresponding source files into this conditional block to ensure build consistency and prevent errors when Thyra is disabled.
|
|
||
| ASSERT_DEFINED(${PACKAGE_NAME}_ENABLE_Thyra) | ||
| IF (${PACKAGE_NAME}_ENABLE_Thyra) | ||
| APPEND_SET(HEADERS |
There was a problem hiding this comment.
The Stratimikos-related headers (Adapters/Stratimikos_FROSch_decl.hpp and Adapters/Stratimikos_FROSch_def.hpp) should also be moved into this conditional block, as they depend on the Stratimikos package (which in turn depends on Thyra). Please ensure they are removed from the main HEADERS list at the top of the file (lines 58-59) to avoid duplication and potential build errors when Thyra is disabled.
APPEND_SET(HEADERS
Adapters/Stratimikos_FROSch_decl.hpp
Adapters/Stratimikos_FROSch_def.hpp
| SolverInterfaces/FROSch_ThyraSolver_decl.hpp | ||
| SolverInterfaces/FROSch_ThyraSolver_def.hpp | ||
| ) | ||
| ENDIF() |
There was a problem hiding this comment.
The corresponding source files (.cpp) for these Thyra and Stratimikos adapters must also be wrapped in a similar IF (${PACKAGE_NAME}_ENABLE_Thyra) block in the SOURCES section (starting at line 161). If the source files are not guarded, the build will still fail during compilation even if the headers are correctly handled in the HEADERS list.
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
csiefer2
force-pushed
the
pr-mirror-15183
branch
from
84daf97 to
5faa885
Compare
2 participants
Automated mirror of upstream PR trilinos#15183 @trilinos/shylu
Motivation
FROSch build fails if Thyra is disabled. This should fix it.