feat: enhance localization methods to use SDK's active locale for plural rules#391
Open
serhii-londar wants to merge 2 commits intomasterfrom
Open
feat: enhance localization methods to use SDK's active locale for plural rules#391serhii-londar wants to merge 2 commits intomasterfrom
serhii-londar wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Enhances the String localization helpers so formatted localization (including .stringsdict plural resolution) uses the SDK’s active localization locale instead of the device locale.
Changes:
- Update
cw_localized(with:)overloads to callString(format:locale:arguments:)with an SDK-derivedLocale. - Add a private
String.crowdinLocalehelper to derive the locale from the SDK’s current localization (with fallback).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 57.30% 56.58% -0.71%
==========================================
Files 134 135 +1
Lines 6540 6623 +83
==========================================
Hits 3747 3747
- Misses 2793 2876 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.