Skip to content

ThreadUtils thread count adjusted to limited value to avoid lockups #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echicoine-icf wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ThreadUtils thread count adjusted to limited value to avoid lockups #555

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34b9107
ThreadUtils thread count adjusted to limited value to avoid lockups i…
Apr 17, 2025
3e5c4b9
Merge branch 'master' into threadutils-threadcount
c-schuler Apr 23, 2025
a26ddce
Merge branch 'master' of https://github.com/echicoine-icf/cqf-tooling…
May 5, 2025
e8f1ac9
-Dthreadutils.pool.count=8 now a possible argument
May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tooling/src/main/java/org/opencds/cqf/tooling/common/ThreadUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ public class ThreadUtils {

private static List<ExecutorService> runningExecutors = new ArrayList<>();

private static final int threadPoolCount = Runtime.getRuntime().availableProcessors() * 2;
Copy link
Copy Markdown
Contributor

@c-schuler c-schuler Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a magic number heuristic here. It makes sense in context, but I would prefer a safer approach, like the following:

private static final int threadPoolCount = Integer.getInteger("threadutils.pool.count", Runtime.getRuntime().availableProcessors());

This allows configuration to override e.g. -Dthreadutils.pool.count=8

Copy link
Copy Markdown
Contributor Author

@echicoine-icf echicoine-icf May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a magic number heuristic here. It makes sense in context, but I would prefer a safer approach, like the following:

private static final int threadPoolCount = Integer.getInteger("threadutils.pool.count", Runtime.getRuntime().availableProcessors());

This allows configuration to override e.g. -Dthreadutils.pool.count=8

I do like this better. Thank you!


/**
* Executes a list of tasks concurrently using a thread pool.
* <p>
Expand Down Expand Up @@ -62,11 +64,15 @@ public static void executeTasks(List<Callable<Void>> tasks, ExecutorService exec
}

public static void executeTasks(List<Callable<Void>> tasks) {
executeTasks(tasks, Executors.newCachedThreadPool());
ExecutorService executor = Executors.newFixedThreadPool(threadPoolCount);

executeTasks(tasks, executor);
}

public static void executeTasks(Queue<Callable<Void>> callables) {
executeTasks(new ArrayList<>(callables), Executors.newCachedThreadPool());
ExecutorService executor = Executors.newFixedThreadPool(threadPoolCount);

executeTasks(new ArrayList<>(callables), executor);
}

public static void shutdownRunningExecutors() {
Expand All @@ -77,7 +83,7 @@ public static void shutdownRunningExecutors() {
}
runningExecutors = new ArrayList<>();
}catch (Exception e){
//fail silently, shutting down anyways
//fail silently, shutting down anyway
}
}
}
Loading