feat: setup#2
Open
igorroncevic wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the example Counter contract with Solver7702Delegate, an ERC-7702 delegation target that forwards calls from authorized addresses. It also updates tool configurations for Solhint, Slither, and Foundry. Feedback identifies a compilation error in the target address extraction logic and suggests using granular Slither suppressions instead of global detector exclusions to preserve security analysis depth.
igorroncevic
commented
May 14, 2026
Comment on lines
+7
to
+9
| "func-visibility": ["error", { "ignoreConstructors": true }], | ||
| "no-complex-fallback": "off", | ||
| "no-inline-assembly": "off" |
Collaborator
Author
There was a problem hiding this comment.
All of these are necessary:
"func-visibility": ["error", { "ignoreConstructors": true }]-> constructor doesn't require explicit visibility modifier since Solidity 0.7"no-complex-fallback": "off"-> we explicitly need our fallback to be complex"no-inline-assembly": "off"-> we explicitly need assembly for gas efficiency
| [fmt] | ||
| sort_imports = true | ||
| number_underscore = "thousands" | ||
| wrap_comments = true |
Collaborator
Author
There was a problem hiding this comment.
Without this, lines can extend without wrapping.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "solidity.compileUsingRemoteVersion": "v0.8.34+commit.80d5c536" | |||
Collaborator
Author
There was a problem hiding this comment.
Explicit requirement for latest Solidity version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up the first version of
Solver7702Delegate, an ERC-7702 delegation target for solver EOAs.The contract lets approved auxiliary EOAs submit calls through the solver EOA. This gives solvers more nonce lanes for settlement submission while keeping the solver EOA as the address seen by downstream contracts.
What changed
Solver7702Delegate.Solver7702Delegate.Countercontract, script, and test.Why
A solver EOA has one nonce lane, so transactions from that EOA must land in order. With ERC-7702, auxiliary EOAs can send transactions to the solver EOA and use their own nonce lanes, while calls still execute as the solver EOA.
This keeps the existing solver identity and avoids having to allowlist several EOAs or require every solver to use a smart contract account.
Out of scope
Testing
Run: