-
Notifications
You must be signed in to change notification settings - Fork 58
feat/refactor: 'expr.transform()'; fixes & refactors to 'replace()' and rule-application #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samueltlg
wants to merge
15
commits into
cortex-js:main
Choose a base branch
from
samueltlg:expr-transform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
adf26f8
fix: do not return 'null' in 'applyRule' if replacement has applied r…
samueltlg 1bf80b5
refactor: optimize rule application by exiting earlier on match-patte…
samueltlg 57ce573
fix (workaround): ensure intended canonical - non-canonical - match …
samueltlg d36d165
fix: do not jointly consider form 'structural' in calculation of 'can…
samueltlg 6e116c1
feat: ReplaceOptions.direction
samueltlg 7d14b6a
fix: do not require '$'-delimited latex strings for object-Rule 'cond…
samueltlg ccd32d6
fix: when parsing an object Rule 'condition', ensure canonical-form (…
samueltlg 12cabb5
fix: consistently return partially-canonicalized expressions as 'stru…
samueltlg 27e8e81
fix: dispatch options (including rules) to simplifyOperands in simpli…
samueltlg 5d974d2
Refactor (workaround): during simplification, do not simplify *all* n…
samueltlg 9c95630
refactor (+fix): update ReplaceOptions.canonical to 'form'; fix: when…
samueltlg 7c761b9
refactor: singular documentative type-cast
samueltlg bec5201
feat: 'assertIsFunction' / 'getOp' utilities
samueltlg e7a30e9
refactor: refine form-cast policy for 'expr.replace()' where form is …
samueltlg 2646bf8
Feat: 'Expression.transform()'
samueltlg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not a test to this... but changing this appeared to correct some behaviours whilst outlining the tests for transform. Throughout the partial-canonicalization process, appears that sometimes the expression is 'intermediarily' not marked as canonical.