Skip to content

Fix installer and downgrader under Windows#919

Merged
aschempp merged 3 commits intocontao:mainfrom
fritzmg:patch-3
Feb 26, 2026
Merged

Fix installer and downgrader under Windows#919
aschempp merged 3 commits intocontao:mainfrom
fritzmg:patch-3

Conversation

@fritzmg
Copy link
Copy Markdown
Contributor

@fritzmg fritzmg commented Feb 22, 2026

Fixes the

rename(public\contao-manager.phar.php.install,public\contao-manager.phar.php): Access is denied (code: 5)
in public\contao-manager.phar.php on line 23

error under Windows.

@fritzmg fritzmg requested a review from aschempp as a code owner February 22, 2026 14:28
@ausi
Copy link
Copy Markdown
Member

ausi commented Feb 22, 2026

I’d prefer to only do that if the orignal rename($tempFile, $fileName) fails because with these changes the install process is no longer “atomic”.

Comment thread installer.php Outdated
@aschempp
Copy link
Copy Markdown
Member

Looks good! Could you apply the same to the downgrade.php?

@fritzmg fritzmg changed the title Fix installer under Windows Fix installer and downgrader under Windows Feb 22, 2026
@aschempp aschempp merged commit d421edc into contao:main Feb 26, 2026
8 checks passed
@aschempp
Copy link
Copy Markdown
Member

Thank you @fritzmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants