Skip to content

Standardized metrics export - feature flagged#125

Open
chrishagglund-ship-it wants to merge 10 commits intomainfrom
gated-metrics-standardization
Open

Standardized metrics export - feature flagged#125
chrishagglund-ship-it wants to merge 10 commits intomainfrom
gated-metrics-standardization

Conversation

@chrishagglund-ship-it
Copy link
Copy Markdown
Contributor

@chrishagglund-ship-it chrishagglund-ship-it commented May 4, 2026

Provides cross-sdk standardized metrics output format, enabled by setting WORKER_CANONICAL_METRICS=true, see standardized metrics catalog for the proposed standard metrics catalog

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 88.36820% with 139 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/sdk/worker/metrics/MetricsCollectorInterface.ts 0.00% 49 Missing ⚠️
...rc/sdk/worker/metrics/CanonicalMetricsCollector.ts 91.63% 43 Missing ⚠️
src/sdk/clients/workflow/WorkflowExecutor.ts 14.28% 24 Missing ⚠️
...dk/createConductorClient/helpers/fetchWithRetry.ts 86.56% 9 Missing ⚠️
src/sdk/worker/core/TaskHandler.ts 85.71% 7 Missing ⚠️
src/sdk/worker/metrics/LegacyMetricsCollector.ts 92.30% 4 Missing ⚠️
.../sdk/worker/metrics/CanonicalPrometheusRegistry.ts 98.21% 3 Missing ⚠️
Flag Coverage Δ
integration-v4 64.49% <33.55%> (-2.55%) ⬇️
integration-v5 69.76% <37.82%> (-3.09%) ⬇️
unit 48.90% <86.27%> (+2.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/sdk/builders/tasks/pullWorkflowMessages.ts 100.00% <100.00%> (ø)
src/sdk/clients/worker/Poller.ts 98.63% <100.00%> (+<0.01%) ⬆️
src/sdk/clients/worker/TaskRunner.ts 100.00% <100.00%> (ø)
src/sdk/clients/worker/events/EventDispatcher.ts 100.00% <100.00%> (ø)
src/sdk/worker/metrics/MetricsServer.ts 100.00% <100.00%> (ø)
src/sdk/worker/metrics/accumulators.ts 100.00% <100.00%> (ø)
src/sdk/worker/metrics/httpObserver.ts 100.00% <100.00%> (ø)
src/sdk/worker/metrics/metricsFactory.ts 100.00% <100.00%> (ø)
.../sdk/worker/metrics/CanonicalPrometheusRegistry.ts 98.21% <98.21%> (ø)
src/sdk/worker/metrics/LegacyMetricsCollector.ts 95.75% <92.30%> (ø)
... and 5 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant