fix: Support overriding $defs / definition#5115
Closed
reteps wants to merge 2 commits intocolinhacks:mainfrom
Closed
fix: Support overriding $defs / definition#5115reteps wants to merge 2 commits intocolinhacks:mainfrom
$defs / definition#5115reteps wants to merge 2 commits intocolinhacks:mainfrom
Conversation
Author
Owner
|
Fixed in #5578 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5103
The previous behavior had this logic:
However, this logic considers the concept of a parent based on the Zod schema; which in certain cases makes it impossible to override a schema with no parent in the outputted JSON Schema. This is a bug fix to support overriding schemas at the root level. An alternative fix would be smarter detection of what counts as a parent schema: considering the concept of 'parent' in a JSON Schema
$refas well.