fix: integrate selection highlighting into cell rendering#87
Merged
Conversation
Fix glyph clipping issue where complex scripts (like Devanagari कवि) would render on top of selection highlights. This happened because selection was drawn as a semi-transparent overlay after all text, causing z-order issues when adjacent rows were re-rendered for glyph overflow handling. Changes: - Integrate selection into renderCellBackground/renderCellText (like Ghostty) - Use solid selection colors instead of semi-transparent overlay - Add isInSelection() helper for efficient cell selection checking - Cache selection coordinates at frame start for performance - Remove separate renderSelection() overlay method - Fix scrollbar fade animations not triggering re-renders - Fix scrollbar ghosting by clearing scrollbar area before redraw - Increase default scrollback from 1000 to 10000 lines (matches Ghostty) This matches how native Ghostty handles selection rendering, where selected cells have their fg/bg colors swapped rather than an overlay drawn on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix glyph clipping issue where complex scripts (like Devanagari कवि) would render on top of selection highlights. This happened because selection was drawn as a semi-transparent overlay after all text, causing z-order issues when adjacent rows were re-rendered for glyph overflow handling.