fix(Filters): check both keys and values in InvalidChars arrays#10303
Open
gr8man wants to merge 5 commits into
Open
fix(Filters): check both keys and values in InvalidChars arrays#10303gr8man wants to merge 5 commits into
gr8man wants to merge 5 commits into
Conversation
michalsn
requested changes
Jun 12, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Please add a changelog entry.
michalsn
added
the
bug
Member
|
Changelog entry should be added here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.7.4.rst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
InvalidCharsfilter where array keys were not being validated.Previously,
checkControl()usedarray_map(), which only applied the callback to the array's values while ignoring the array's keys entirely. Due to this, any control characters or invalid UTF-8 sequences passed through array keys (e.g.$_POST['bad_key']) bypassed the filter.