Skip to content

Remove chsh check around updating a users default shell to bash#3160

Merged
sebjulliand merged 1 commit intocodefori:masterfrom
Nathaniel-King-Navarrete:bug/call_default_not_bash_error_even_if_chsh_is_not_installed
Apr 21, 2026
Merged

Remove chsh check around updating a users default shell to bash#3160
sebjulliand merged 1 commit intocodefori:masterfrom
Nathaniel-King-Navarrete:bug/call_default_not_bash_error_even_if_chsh_is_not_installed

Conversation

@Nathaniel-King-Navarrete
Copy link
Copy Markdown
Contributor

Changes

Since pr #3131 allows us to fallback on SQL to set bash as default shell. We no longer need to check for chsh to be installed before throwing the default_not_bash connection error code

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

Copy link
Copy Markdown
Member

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, thanks!

@sebjulliand sebjulliand merged commit ce21943 into codefori:master Apr 21, 2026
2 checks passed
@Nathaniel-King-Navarrete Nathaniel-King-Navarrete deleted the bug/call_default_not_bash_error_even_if_chsh_is_not_installed branch April 21, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants