[codex] Correct neo TUI screenshot capture docs#23
Closed
IYENTeam wants to merge 1 commit into
Closed
Conversation
The screenshot README described a faux-backend/live-RPC capture flow and persistent evidence directory, but the checked-in script captures demo scenes and deletes temporary ANSI/HTML intermediates. Update the docs to match the script so screenshot maintenance starts from the right runtime contract.\n\nConstraint: Keep the existing screenshot generation script unchanged.\nRejected: Rewrite capture-screenshots.sh to use the faux backend | this PR only corrects documentation drift, and changing PNG generation behavior should be reviewed separately.\nConfidence: high\nScope-risk: narrow\nTested: git diff --check\nNot-tested: Full screenshot regeneration; local aha is not installed and regeneration would overwrite checked-in PNGs
Owner
|
[sisyphus-bot] Thanks for fixing up the neo TUI screenshot capture docs, IYEN. This PR no longer has a target, though: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
packages/neo-tui/docs/screenshots/README.mdto matchscripts/capture-screenshots.sh.senpi-neo-tui --demo --demo-seconds 600, not from the faux backend/live RPC path.Why
The screenshot documentation described a different capture pipeline than the checked-in script, which could lead maintainers to debug the wrong runtime path when regenerating screenshots.
Validation
git diff --checknpm run checkNot tested
ahais not installed and regeneration would overwrite checked-in PNG artifacts.Summary by cubic
Update
packages/neo-tui/docs/screenshots/README.mdto match the capture flow inscripts/capture-screenshots.sh. Overlays are now documented as captured fromsenpi-neo-tui --demo --demo-seconds 600(not the faux RPC backend), and the ANSI/HTML intermediates are temporary and cleaned up.Written for commit 62627fe. Summary will update on new commits. Review in cubic