Skip to content

refactor(kimi-web-search): rename tools to snake_case for consistency#20

Merged
code-yeongyu merged 2 commits into
code-yeongyu:mainfrom
ckanner:feat/rename-kimi-tools
Jun 15, 2026
Merged

refactor(kimi-web-search): rename tools to snake_case for consistency#20
code-yeongyu merged 2 commits into
code-yeongyu:mainfrom
ckanner:feat/rename-kimi-tools

Conversation

@ckanner

@ckanner ckanner commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Renames SearchWeb/FetchURL to kimi_search_web/kimi_fetch_url to align with senpi/pi-mono tool naming conventions.

Problem

The current tool names use PascalCase (SearchWeb, FetchURL), inherited from Kimi CLI's class names. This is inconsistent with every other tool in the senpi ecosystem:

Tool Naming
read, write, edit, bash lowercase
apply_patch, multiedit snake_case
web_search (anthropic-web-search) snake_case
todowrite, todoread lowercase
SearchWeb, FetchURL (kimi-web-search) PascalCase

Solution

  • SearchWebkimi_search_web
  • FetchURLkimi_fetch_url

This makes the tool names consistent with:

  1. The rest of senpi's builtin extensions
  2. Third-party extensions (e.g., pi-websearch uses web_search)
  3. The general Unix/CLI convention of snake_case for identifiers

Changes

  • packages/coding-agent/src/core/extensions/builtin/kimi-web-search/index.ts
    • name, label, description, promptSnippet updated

Checklist

  • Pre-commit checks pass (Biome + tsgo + browser-smoke + web-ui)
  • Atomic commit with clear rationale
  • No breaking changes to tool schema (only the tool name changed)

Migration

Users with permission rules for SearchWeb/FetchURL need to update:

"permission": {
  "kimi_search_web": "allow",
  "kimi_fetch_url": "allow"
}

Refs: #10


Summary by cubic

Renamed SearchWeb and FetchURL to kimi_search_web and kimi_fetch_url for consistent snake_case tool names across senpi/pi-mono, and updated regression tests. Aligns with #10; no schema or behavior changes.

  • Migration
    • Update any permission rules or references: SearchWebkimi_search_web, FetchURLkimi_fetch_url.

Written for commit ba84934. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

ckanner added 2 commits June 15, 2026 12:33
Rename SearchWeb/FetchURL to kimi_search_web/kimi_fetch_url to align
with senpi/pi-mono tool naming conventions (snake_case/lowercase).

All other builtin and third-party tools use snake_case:
- read, write, edit, bash
- web_search, apply_patch, multiedit
- todowrite, todoread

PascalCase (SearchWeb/FetchURL) was inherited from Kimi CLI but is
inconsistent with the rest of the extension ecosystem.

Refs: code-yeongyu#10
@code-yeongyu code-yeongyu force-pushed the feat/rename-kimi-tools branch from ec1be28 to ba84934 Compare June 15, 2026 03:34
@code-yeongyu code-yeongyu merged commit d0cea02 into code-yeongyu:main Jun 15, 2026
2 of 3 checks passed
@code-yeongyu

Copy link
Copy Markdown
Owner

[sisyphus-bot] Rebased this branch cleanly onto the latest main (no conflicts) and verified the diff end to end before merging.

Verification I ran on the rebased tree:

  • Static gate: git grep -n "SearchWeb|FetchURL" -- packages/coding-agent/src packages/coding-agent/test shows no remaining tool-registration usages. The only hits are the internal TypeScript type identifiers (SearchWebInput / FetchUrlInput), which are out of scope for a tool-name rename, plus the historical note in changes.md. Both kimi_search_web and kimi_fetch_url are present in index.ts (name, label, description, promptSnippet) and in the 3592 regression test.
  • Functional gate: npm ci --ignore-scripts at the repo root, then npx vitest --run test/suite/regressions/3592-no-builtin-tools-keeps-extension-tools.test.ts (3/3 passed), and npx tsgo --noEmit from the repo root (clean, exit 0).

Merged via a merge commit. Thanks for the tidy, focused change, ckanner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants