Fix cinema mode overlay blocking video screen (#3765) & Playlist Reverse #3766
Fix cinema mode overlay blocking video screen (#3765) & Playlist Reverse #3766suryaprakash0010 wants to merge 2 commits intocode-charity:masterfrom
Conversation
Added 'position: relative' when bringing player container elements to the front so layer z-index operates correctly over the cinema backdrop. Also expanded logic to seamlessly protect '#ytd-player' elements.
…ode-charity#3759) Resolved an issue where reverse playlist would flip back to its original order when playing the next video, because YouTube's SPA navigation updates the playlist array in-place, bypassing object references. ImprovedTube.playlistReverseUpdate now verifies the visual sort array index natively instead of using the custom 'it_reversed' flag. Also restored 'playlistReversed' from local storage properly so it persists after page refreshes.
|
Hi again @suryaprakash0010 and thank you! |
| if (message.action === 'storage-loaded') { | ||
| ImprovedTube.storage = message.storage; | ||
|
|
||
| if (typeof ImprovedTube.storage.playlist_reversed_active !== 'undefined') { |
There was a problem hiding this comment.
Unrelated to the cinema mode fix. This is a playlist feature change bundled into a cinema-mode bug fix PR. Please once check!!
|
|
||
| // Use idempotent flag to prevent double reversal (Fix #3733) | ||
| var isCurrentlyReversed = playlist.it_reversed === true; | ||
| // Determine if currently reversed by checking YouTube's own index properties, which is 100% foolproof |
There was a problem hiding this comment.
Entirely unrelated to cinema mode. This is a significant logic change to playlist reversal detection and should be a separate PR.
|
@suryaprakash0010 comments!! |
ImprovedTube
changed the title
ImprovedTube
changed the title
|
@rajanarahul93, oh sorry, i could have introduced the PR as unclear / two in one! (As repo maintainer i might not wonder unless i see something like +5 million lines). Was just glad both of you guys are active and happy if i ever start a teamwork among who watched the same code recently (didn't always occur in this repo!) - hi @li224242 ( #3643 ) (And for this feature the users wrote many hopeful and frustrated reviews for years after a standalone extension stopped and our playlist buttons might disappeared in Youtube's shadow DOM) (And i would love to work on lists and #1546) ( previous Cinema Mode PRs ) |
|
@ImprovedTube if two features fixes can be in the same pr then no changes required ig!! |
ImprovedTube
added
untested
3 participants
Fixed cinema mode overlay blocking video screen (#3765)" -m "Added 'position: relative' when bringing player container elements to the front so layer z-index operates correctly over the cinema backdrop. Also expanded logic to seamlessly protect '#ytd-player' elements.