fix: ensure ImprovedTube volume settings apply to all iframes#3688
Draft
sebmuehlbauer wants to merge 1 commit intocode-charity:masterfrom
Draft
fix: ensure ImprovedTube volume settings apply to all iframes#3688sebmuehlbauer wants to merge 1 commit intocode-charity:masterfrom
sebmuehlbauer wants to merge 1 commit intocode-charity:masterfrom
Conversation
sebmuehlbauer
force-pushed
the
pangea/fix-issue-1637
branch
4 times, most recently
from
6fffb97 to
e8e7944
Compare
sebmuehlbauer
force-pushed
the
pangea/fix-issue-1637
branch
from
e8e7944 to
a64d690
Compare
Member
|
hallucination |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1637
The issue where the embedded YouTube player ignores forced volume on initial load or hard refresh is primarily due to content scripts not being consistently applied to all subframes (especially when iframes are nested or loaded dynamically).
By setting
"all_frames": trueinmanifest.json, we ensure the content script is injected into every frame of the YouTube/YouTube-nocookie page, allowing the volume control logic to trigger correctly even inside iframes. This addresses the discrepancy seen in Incognito mode where script execution timing can be more restrictive.This PR was autonomously generated by Pangea 3 — an AI-powered development system.